Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Side by Side Diff: courgette/program_detector.cc

Issue 2583373002: [Courgette] Simple AssemblyProgram and Disassembler cleanups. (Closed)
Patch Set: Sync. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "courgette/program_detector.h" 5 #include "courgette/program_detector.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "courgette/assembly_program.h" 9 #include "courgette/assembly_program.h"
10 #include "courgette/disassembler.h" 10 #include "courgette/disassembler.h"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 size_t length, 70 size_t length,
71 std::unique_ptr<AssemblyProgram>* output) { 71 std::unique_ptr<AssemblyProgram>* output) {
72 output->reset(); 72 output->reset();
73 73
74 std::unique_ptr<Disassembler> disassembler( 74 std::unique_ptr<Disassembler> disassembler(
75 DetectDisassembler(buffer, length)); 75 DetectDisassembler(buffer, length));
76 if (!disassembler) 76 if (!disassembler)
77 return C_INPUT_NOT_RECOGNIZED; 77 return C_INPUT_NOT_RECOGNIZED;
78 78
79 std::unique_ptr<AssemblyProgram> program( 79 std::unique_ptr<AssemblyProgram> program(
80 new AssemblyProgram(disassembler->kind())); 80 new AssemblyProgram(disassembler->kind(), disassembler->image_base()));
grt (UTC plus 2) 2017/01/12 11:56:41 base::MakeUnique
huangs 2017/01/12 19:54:42 Done.
81 81
82 if (!disassembler->Disassemble(program.get())) 82 if (!disassembler->Disassemble(program.get()))
83 return C_DISASSEMBLY_FAILED; 83 return C_DISASSEMBLY_FAILED;
84 84
85 *output = std::move(program); 85 *output = std::move(program);
86 return C_OK; 86 return C_OK;
87 } 87 }
88 88
89 } // namespace courgette 89 } // namespace courgette
OLDNEW
« courgette/disassembler_win32.cc ('K') | « courgette/disassembler_win32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698