Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/md_history/lazy_load.vulcanized.html

Issue 2583353003: MD History: Replace last usage of cr-shared-menu with cr-action-menu. (Closed)
Patch Set: Fix more Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/md_history/lazy_load.crisper.js ('k') | chrome/browser/resources/md_history/list_container.html » ('j') | chrome/browser/resources/md_history/list_container.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_history/lazy_load.vulcanized.html
diff --git a/chrome/browser/resources/md_history/lazy_load.vulcanized.html b/chrome/browser/resources/md_history/lazy_load.vulcanized.html
index 23ee2097ea9a172744681fcb7573acfa4e56cc20..fb69ee68e2a51d80f56aa008bd60242b62c0777f 100644
--- a/chrome/browser/resources/md_history/lazy_load.vulcanized.html
+++ b/chrome/browser/resources/md_history/lazy_load.vulcanized.html
@@ -78,11 +78,19 @@ a {
justify-content: center;
}
-.menu-item {
- -webkit-user-select: none;
+.dropdown-item {
+ align-items: center;
+ background: none;
+ border: none;
+ box-sizing: border-box;
+ color: var(--paper-grey-800);
cursor: pointer;
+ display: flex;
font: inherit;
- white-space: nowrap;
+ min-height: 32px;
+ padding: 0 24px;
+ text-align: start;
+ width: 100%;
}
.website-icon {
@@ -252,8 +260,6 @@ history-item {
</style>
</template>
</dom-module>
-
-
<dom-module id="paper-button" assetpath="chrome://resources/polymer/v1_0/paper-button/" css-build="shadow">
<template strip-whitespace="">
<style scope="paper-button">:host {
@@ -373,7 +379,7 @@ paper-ripple {
}
:host([disabled]), .paper-item[disabled] {
- color: var(--paper-item-disabled-color,var(--disabled-text-color));;
+ color: var(--paper-item-disabled-color,var(--disabled-text-color));
;
}
@@ -399,8 +405,6 @@ paper-ripple {
</style>
</template>
</dom-module>
-
-
<dom-module id="paper-item" assetpath="chrome://resources/polymer/v1_0/paper-item/" css-build="shadow">
<template>
@@ -431,7 +435,7 @@ paper-ripple {
}
:host([disabled]), .paper-item[disabled] {
- color: var(--paper-item-disabled-color,var(--disabled-text-color));;
+ color: var(--paper-item-disabled-color,var(--disabled-text-color));
;
}
@@ -468,96 +472,6 @@ paper-ripple {
</template>
</dom-module>
-<dom-module id="iron-overlay-backdrop" assetpath="chrome://resources/polymer/v1_0/iron-overlay-behavior/" css-build="shadow">
-
- <template>
- <style scope="iron-overlay-backdrop">:host {
- position: fixed;
- top: 0;
- left: 0;
- width: 100%;
- height: 100%;
- background-color: var(--iron-overlay-backdrop-background-color, #000);
- opacity: 0;
- transition: opacity 0.2s;
- pointer-events: none;
- ;
-}
-
-:host(.opened) {
- opacity: var(--iron-overlay-backdrop-opacity, 0.6);
- pointer-events: auto;
- ;
-}
-
-</style>
-
- <content></content>
- </template>
-
-</dom-module>
-
-<script src="chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js"></script>
-
-
-<dom-module id="iron-dropdown" assetpath="chrome://resources/polymer/v1_0/iron-dropdown/" css-build="shadow">
- <template>
- <style scope="iron-dropdown">:host {
- position: fixed;
-}
-
-#contentWrapper ::content > * {
- overflow: auto;
-}
-
-#contentWrapper.animating ::content > * {
- overflow: hidden;
-}
-
-</style>
-
- <div id="contentWrapper">
- <content id="content" select=".dropdown-content"></content>
- </div>
- </template>
-
- </dom-module>
-<dom-module id="paper-listbox" assetpath="chrome://resources/polymer/v1_0/paper-listbox/" css-build="shadow">
- <template>
- <style scope="paper-listbox">:host {
- display: block;
- padding: 8px 0;
-
- background: var(--paper-listbox-background-color,var(--primary-background-color));;
- color: var(--paper-listbox-color,var(--primary-text-color));;
-
- ;
-}
-
-</style>
-
- <content></content>
- </template>
-
- </dom-module>
-<dom-module id="cr-shared-menu" assetpath="chrome://resources/cr_elements/cr_shared_menu/" css-build="shadow">
- <template>
- <style scope="cr-shared-menu">paper-listbox {
- box-shadow: var(--shadow-elevation-2dp_-_box-shadow);
- overflow: hidden;
- position: relative;
- width: var(--cr-shared-menu-width);
-}
-
-</style>
- <iron-dropdown id="dropdown" allow-outside-scroll="" restore-focus-on-close="" vertical-align="auto" horizontal-align="right" opened="{{menuOpen}}" open-animation-config="[[openAnimationConfig]]" close-animation-config="[[closeAnimationConfig]]">
- <paper-listbox id="menu" class="dropdown-content">
- <content></content>
- </paper-listbox>
- </iron-dropdown>
- </template>
- </dom-module>
-
<dom-module id="paper-icon-button-light" assetpath="chrome://resources/polymer/v1_0/paper-icon-button/" css-build="shadow">
<template strip-whitespace="">
<style scope="paper-icon-button-light">:host {
@@ -631,11 +545,19 @@ a {
justify-content: center;
}
-.menu-item {
- -webkit-user-select: none;
+.dropdown-item {
+ align-items: center;
+ background: none;
+ border: none;
+ box-sizing: border-box;
+ color: var(--paper-grey-800);
cursor: pointer;
+ display: flex;
font: inherit;
- white-space: nowrap;
+ min-height: 32px;
+ padding: 0 24px;
+ text-align: start;
+ width: 100%;
}
.website-icon {
@@ -821,11 +743,19 @@ a {
justify-content: center;
}
-.menu-item {
- -webkit-user-select: none;
+.dropdown-item {
+ align-items: center;
+ background: none;
+ border: none;
+ box-sizing: border-box;
+ color: var(--paper-grey-800);
cursor: pointer;
+ display: flex;
font: inherit;
- white-space: nowrap;
+ min-height: 32px;
+ padding: 0 24px;
+ text-align: start;
+ width: 100%;
}
.website-icon {
@@ -900,6 +830,22 @@ paper-spinner {
cursor: var(--cr-actionable_-_cursor);
}
+button[is='paper-icon-button-light'].subpage-arrow {
+ background-image: url("chrome://resources/images/arrow_right.svg");
+}
+
+button[is='paper-icon-button-light'].icon-external {
+ background-image: url("chrome://resources/images/open_in_new.svg");
+}
+
+.subpage-arrow, .icon-external {
+ display: none;
+}
+
+[actionable] :-webkit-any(.subpage-arrow, .icon-external), [actionable]:-webkit-any(.subpage-arrow, .icon-external) {
+ display: block;
+}
+
[scrollable] {
border-color: transparent;
border-style: solid;
@@ -1008,14 +954,14 @@ paper-spinner {
</div>
<template is="cr-lazy-render" id="menu">
- <cr-shared-menu>
- <paper-item id="menuOpenButton" class="menu-item" on-tap="onOpenAllTap_">
+ <dialog is="cr-action-menu">
+ <button id="menuOpenButton" class="dropdown-item" on-tap="onOpenAllTap_">
$i18n{openAll}
- </paper-item>
- <paper-item id="menuDeleteButton" class="menu-item" on-tap="onDeleteSessionTap_">
+ </button>
+ <button id="menuDeleteButton" class="dropdown-item" on-tap="onDeleteSessionTap_">
$i18n{deleteSession}
- </paper-item>
- </cr-shared-menu>
+ </button>
+ </dialog>
</template>
</template>
</dom-module>
@@ -1115,6 +1061,94 @@ paper-spinner {
</dom-module>
+<dom-module id="iron-overlay-backdrop" assetpath="/" css-build="shadow">
+
+ <template>
+ <style scope="iron-overlay-backdrop">:host {
+ position: fixed;
+ top: 0;
+ left: 0;
+ width: 100%;
+ height: 100%;
+ background-color: var(--iron-overlay-backdrop-background-color, #000);
+ opacity: 0;
+ transition: opacity 0.2s;
+ pointer-events: none;
+ ;
+}
+
+:host(.opened) {
+ opacity: var(--iron-overlay-backdrop-opacity, 0.6);
+ pointer-events: auto;
+ ;
+}
+
+</style>
+
+ <content></content>
+ </template>
+
+</dom-module>
+
+<script src="chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js"></script><dom-module id="iron-dropdown" assetpath="chrome://resources/polymer/v1_0/iron-dropdown/" css-build="shadow">
+ <template>
+ <style scope="iron-dropdown">:host {
+ position: fixed;
+}
+
+#contentWrapper ::content > * {
+ overflow: auto;
+}
+
+#contentWrapper.animating ::content > * {
+ overflow: hidden;
+}
+
+</style>
+
+ <div id="contentWrapper">
+ <content id="content" select=".dropdown-content"></content>
+ </div>
+ </template>
+
+ </dom-module>
+<dom-module id="paper-listbox" assetpath="chrome://resources/polymer/v1_0/paper-listbox/" css-build="shadow">
+ <template>
+ <style scope="paper-listbox">:host {
+ display: block;
+ padding: 8px 0;
+
+ background: var(--paper-listbox-background-color,var(--primary-background-color));
+ color: var(--paper-listbox-color,var(--primary-text-color));
+
+ ;
+}
+
+</style>
+
+ <content></content>
+ </template>
+
+ </dom-module>
+<dom-module id="cr-shared-menu" assetpath="chrome://resources/cr_elements/cr_shared_menu/" css-build="shadow">
+ <template>
+ <style scope="cr-shared-menu">paper-listbox {
+ box-shadow: var(--shadow-elevation-2dp_-_box-shadow);
+ overflow: hidden;
+ position: relative;
+ width: var(--cr-shared-menu-width);
+}
+
+</style>
+ <iron-dropdown id="dropdown" allow-outside-scroll="" restore-focus-on-close="" vertical-align="auto" horizontal-align="right" opened="{{menuOpen}}" open-animation-config="[[openAnimationConfig]]" close-animation-config="[[closeAnimationConfig]]">
+ <paper-listbox id="menu" class="dropdown-content">
+ <content></content>
+ </paper-listbox>
+ </iron-dropdown>
+ </template>
+ </dom-module>
+
+
<dom-module id="app-drawer" assetpath="chrome://resources/polymer/v1_0/app-layout/app-drawer/" css-build="shadow">
<template>
<style scope="app-drawer">:host {
@@ -1281,7 +1315,7 @@ paper-spinner {
}
paper-ripple {
- color: var(--paper-tab-ink,var(--paper-yellow-a100));;
+ color: var(--paper-tab-ink,var(--paper-yellow-a100));
}
.tab-content > ::content > a {
@@ -1304,8 +1338,6 @@ paper-ripple {
<g id="chevron-right"><path d="M10 6L8.59 7.41 13.17 12l-4.58 4.59L10 18l6-6z"></path></g>
</defs></svg>
</iron-iconset-svg>
-
-
<dom-module id="paper-tabs" assetpath="chrome://resources/polymer/v1_0/paper-tabs/" css-build="shadow">
<template>
<style scope="paper-tabs">:host {
@@ -1388,7 +1420,7 @@ paper-icon-button {
bottom: 0;
left: 0;
right: 0;
- background-color: var(--paper-tabs-selection-bar-color,var(--paper-yellow-a100));;
+ background-color: var(--paper-tabs-selection-bar-color,var(--paper-yellow-a100));
-webkit-transform: scale(0);
transform: scale(0);
-webkit-transform-origin: left center;
@@ -1434,4 +1466,4 @@ paper-icon-button {
</template>
</dom-module>
-</div><script src="lazy_load.crisper.js"></script></body></html>
+</div><script src="lazy_load.crisper.js"></script></body></html>
« no previous file with comments | « chrome/browser/resources/md_history/lazy_load.crisper.js ('k') | chrome/browser/resources/md_history/list_container.html » ('j') | chrome/browser/resources/md_history/list_container.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698