MD History: Replace last usage of cr-shared-menu with cr-action-menu.

chrome/browser/resources/md_history/synced_device_manager.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @typedef {{device: string,
  *           lastUpdateTime: string,
  *           opened: boolean,
  *           separatorIndexes: !Array<number>,
  *           timestamp: number,
@@ skipping 30 matching lines @@
       type: Boolean,
       value: loadTimeData.getBoolean('isGuestSession'),
     },
 
     /** @private */
     fetchingSyncedTabs_: {
       type: Boolean,
       value: false,
     },
 
+    /** @private */
     hasSeenForeignData_: Boolean,
+
+    /**
+     * The session ID referring to the currently active action menu.
+     * @private {?string}
+     */
+    actionMenuModel_: String,
   },
 
   listeners: {
-    'toggle-menu': 'onToggleMenu_',
-    'scroll': 'onListScroll_',
+    'open-menu': 'onOpenMenu_',
     'update-focus-grid': 'updateFocusGrid_',
   },
 
   /** @type {?cr.ui.FocusGrid} */
   focusGrid_: null,
 
   /** @override */
   attached: function() {
     this.focusGrid_ = new cr.ui.FocusGrid();
 
@@ skipping 54 matching lines @@
       timestamp: session.timestamp,
       tabs: tabs,
       tag: session.tag,
     };
   },
 
   /** @private */
   onSignInTap_: function() { chrome.send('startSignInFlow'); },
 
   /** @private */
-  onListScroll_: function() {
-    var menu = this.$.menu.getIfExists();
-    if (menu)
-      menu.closeMenu();
+  onOpenMenu_: function(e) {
+    var menu = /** @type {CrSharedMenuElement} */ this.$.menu.get();

[tsergeant, 2016/12/21 00:39:36]

CrActionMenuElement, now

(it's weird that closure didn't complain about this =S)

[dpapad, 2016/12/21 01:04:48]

Done, and yes, something is fishy. Closure should have caught that (this file
has an equivalent compile target in compiled_resources2.gyp).

+    this.actionMenuModel_ = e.detail.tag;
+    menu.showAt(e.detail.target);
+    md_history.BrowserService.getInstance().recordHistogram(
+        SYNCED_TABS_HISTOGRAM_NAME, SyncedTabsHistogram.SHOW_SESSION_MENU,
+        SyncedTabsHistogram.LIMIT);
   },
 
   /** @private */
-  onToggleMenu_: function(e) {
-    var menu = /** @type {CrSharedMenuElement} */ this.$.menu.get();
-    menu.toggleMenu(e.detail.target, e.detail.tag);
-    if (menu.menuOpen) {
-      md_history.BrowserService.getInstance().recordHistogram(
-          SYNCED_TABS_HISTOGRAM_NAME, SyncedTabsHistogram.SHOW_SESSION_MENU,
-          SyncedTabsHistogram.LIMIT);
-    }
-  },
-
-  /** @private */
   onOpenAllTap_: function() {
     var menu = assert(this.$.menu.getIfExists());
     var browserService = md_history.BrowserService.getInstance();
     browserService.recordHistogram(
         SYNCED_TABS_HISTOGRAM_NAME, SyncedTabsHistogram.OPEN_ALL,
         SyncedTabsHistogram.LIMIT);
-    browserService.openForeignSessionAllTabs(
-        menu.itemData);
-    menu.closeMenu();
+    browserService.openForeignSessionAllTabs(assert(this.actionMenuModel_));
+    this.actionMenuModel_ = null;
+    menu.close();
   },
 
   /** @private */
   updateFocusGrid_: function() {
     if (!this.focusGrid_)
       return;
 
     this.focusGrid_.destroy();
 
     this.debounce('updateFocusGrid', function() {
       Polymer.dom(this.root)
           .querySelectorAll('history-synced-device-card')
           .reduce(
               function(prev, cur) {
                 return prev.concat(cur.createFocusRows());
               },
               [])
           .forEach(function(row) { this.focusGrid_.addRow(row); }.bind(this));
       this.focusGrid_.ensureRowActive();
     });
   },
 
   /** @private */
   onDeleteSessionTap_: function() {
     var menu = assert(this.$.menu.getIfExists());
     var browserService = md_history.BrowserService.getInstance();
     browserService.recordHistogram(
         SYNCED_TABS_HISTOGRAM_NAME, SyncedTabsHistogram.HIDE_FOR_NOW,
         SyncedTabsHistogram.LIMIT);
-    browserService.deleteForeignSession(menu.itemData);
-    menu.closeMenu();
+    browserService.deleteForeignSession(assert(this.actionMenuModel_));
+    this.actionMenuModel_ = null;
+    menu.close();
   },
 
   /** @private */
   clearDisplayedSyncedDevices_: function() { this.syncedDevices_ = []; },
 
   /**
    * Decide whether or not should display no synced tabs message.
    * @param {boolean} signInState
    * @param {number} syncedDevicesLength
    * @param {boolean} guestSession
@@ skipping 83 matching lines @@
     // User signed in, show the loading message when querying for synced
     // devices.
     this.fetchingSyncedTabs_ = true;
   },
 
   searchTermChanged: function(searchTerm) {
     this.clearDisplayedSyncedDevices_();
     this.updateSyncedDevices(this.sessionList);
   }
 });