Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2583313002: Added thread.dart and zone.dart to the observatory sources to resolve build issues. (Closed)

Created:
4 years ago by bkonyi
Modified:
4 years ago
Reviewers:
zra, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added thread.dart and zone.dart to the observatory sources to resolve build issues. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/5bf4fcee29533453a00c7978b537a90e0e257bde

Patch Set 1 #

Patch Set 2 : Added ability to request zone memory information for all isolates through the VM service and added … #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -0 lines) Patch
M runtime/observatory/lib/models.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/isolate.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/models/objects/thread.dart View 1 1 chunk +25 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/models/objects/zone.dart View 1 1 chunk +14 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 4 chunks +63 lines, -0 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/get_zone_memory_info_rpc_test.dart View 1 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bkonyi
Made the changes to observatory_sources.gypi that John suggested. Are there any other files that I ...
4 years ago (2016-12-19 19:38:51 UTC) #2
Cutch
On 2016/12/19 19:38:51, bkonyi wrote: > Made the changes to observatory_sources.gypi that John suggested. Are ...
4 years ago (2016-12-19 20:15:07 UTC) #3
bkonyi
4 years ago (2016-12-19 20:36:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5bf4fcee29533453a00c7978b537a90e0e257bde (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698