Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3287)

Unified Diff: extensions/renderer/argument_spec_unittest.cc

Issue 2583273002: [Extensions Bindings] Allow for argument validation without conversion (Closed)
Patch Set: format Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/argument_spec_unittest.cc
diff --git a/extensions/renderer/argument_spec_unittest.cc b/extensions/renderer/argument_spec_unittest.cc
index ac4d152eb762c9f1e1a4ebcf547936f37449ba1d..8eabdeb1bebfa3cc7781ca51102daaba82d97c57 100644
--- a/extensions/renderer/argument_spec_unittest.cc
+++ b/extensions/renderer/argument_spec_unittest.cc
@@ -71,10 +71,12 @@ void ArgumentSpecUnitTest::RunTest(const ArgumentSpec& spec,
ASSERT_FALSE(val.IsEmpty()) << script_source;
std::string error;
- std::unique_ptr<base::Value> out_value =
- spec.ConvertArgument(context, val, type_refs_, &error);
+ std::unique_ptr<base::Value> out_value;
+ bool did_succeed =
+ spec.ParseArgument(context, val, type_refs_, &out_value, &error);
bool should_succeed = expected_result == TestResult::PASS;
- ASSERT_EQ(should_succeed, !!out_value) << script_source << ", " << error;
+ ASSERT_EQ(should_succeed, did_succeed) << script_source << ", " << error;
+ ASSERT_EQ(did_succeed, !!out_value);
bool should_throw = expected_result == TestResult::THROW;
ASSERT_EQ(should_throw, try_catch.HasCaught()) << script_source;
if (should_succeed) {
« extensions/renderer/api_signature.cc ('K') | « extensions/renderer/argument_spec.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698