third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp - Issue 2583233002: Migrate WTF::Vector::append() to ::push_back() [part 7 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

Issue 2583233002: Migrate WTF::Vector::append() to ::push_back() [part 7 of N] (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp ('k') | third_party/WebKit/Source/core/html/parser/TextDocumentParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp b/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

index 17d9757770ceb1d603da3e0cf3158f57010e8c09..75b31a888320c604bb2cc08e9381a9fd0c41d030 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

@@ -95,7 +95,7 @@ static bool tokenExitsMath(const CompactHTMLToken& token) {

HTMLTreeBuilderSimulator::HTMLTreeBuilderSimulator(

const HTMLParserOptions& options)

: m_options(options) {

- m_namespaceStack.append(HTML);

+ m_namespaceStack.push_back(HTML);

}

HTMLTreeBuilderSimulator::State HTMLTreeBuilderSimulator::stateFor(

@@ -112,7 +112,7 @@ HTMLTreeBuilderSimulator::State HTMLTreeBuilderSimulator::stateFor(

currentNamespace = MathML;

if (namespaceStack.isEmpty() || namespaceStack.back() != currentNamespace)

- namespaceStack.append(currentNamespace);

+ namespaceStack.push_back(currentNamespace);

}

namespaceStack.reverse();

return namespaceStack;

@@ -126,14 +126,14 @@ HTMLTreeBuilderSimulator::SimulatedToken HTMLTreeBuilderSimulator::simulate(

if (token.type() == HTMLToken::StartTag) {

const String& tagName = token.data();

if (threadSafeMatch(tagName, SVGNames::svgTag))

- m_namespaceStack.append(SVG);

+ m_namespaceStack.push_back(SVG);

if (threadSafeMatch(tagName, MathMLNames::mathTag))

- m_namespaceStack.append(MathML);

+ m_namespaceStack.push_back(MathML);

if (inForeignContent() && tokenExitsForeignContent(token))

m_namespaceStack.pop_back();

if ((m_namespaceStack.back() == SVG && tokenExitsSVG(token)) ||

(m_namespaceStack.back() == MathML && tokenExitsMath(token)))

- m_namespaceStack.append(HTML);

+ m_namespaceStack.push_back(HTML);

if (!inForeignContent()) {

// FIXME: This is just a copy of Tokenizer::updateStateFor which uses

// threadSafeMatches.