Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: third_party/WebKit/Source/core/html/forms/FileInputTypeTest.cpp

Issue 2583233002: Migrate WTF::Vector::append() to ::push_back() [part 7 of N] (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/FileInputTypeTest.cpp
diff --git a/third_party/WebKit/Source/core/html/forms/FileInputTypeTest.cpp b/third_party/WebKit/Source/core/html/forms/FileInputTypeTest.cpp
index 3e8f3b884d5c4b68a651fcf6a1555995c67bac3b..aba6482b705910f8d7bc70bcd905831e30d2edd3 100644
--- a/third_party/WebKit/Source/core/html/forms/FileInputTypeTest.cpp
+++ b/third_party/WebKit/Source/core/html/forms/FileInputTypeTest.cpp
@@ -19,7 +19,8 @@ TEST(FileInputTypeTest, createFileList) {
Vector<FileChooserFileInfo> files;
// Native file.
- files.append(FileChooserFileInfo("/native/path/native-file", "display-name"));
+ files.push_back(
+ FileChooserFileInfo("/native/path/native-file", "display-name"));
// Non-native file.
KURL url(ParsedURLStringTag(),
@@ -27,7 +28,7 @@ TEST(FileInputTypeTest, createFileList) {
FileMetadata metadata;
metadata.length = 64;
metadata.modificationTime = 1.0 * msPerDay + 3;
- files.append(FileChooserFileInfo(url, metadata));
+ files.push_back(FileChooserFileInfo(url, metadata));
FileList* list = FileInputType::createFileList(files, false);
ASSERT_TRUE(list);
@@ -81,16 +82,16 @@ TEST(FileInputTypeTest, setFilesFromPaths) {
HTMLInputElement* input = HTMLInputElement::create(*document, false);
InputType* fileInput = FileInputType::create(*input);
Vector<String> paths;
- paths.append("/native/path");
- paths.append("/native/path2");
+ paths.push_back("/native/path");
+ paths.push_back("/native/path2");
fileInput->setFilesFromPaths(paths);
ASSERT_EQ(1u, fileInput->files()->length());
EXPECT_EQ(String("/native/path"), fileInput->files()->item(0)->path());
// Try to upload multiple files without multipleAttr
paths.clear();
- paths.append("/native/path1");
- paths.append("/native/path2");
+ paths.push_back("/native/path1");
+ paths.push_back("/native/path2");
fileInput->setFilesFromPaths(paths);
ASSERT_EQ(1u, fileInput->files()->length());
EXPECT_EQ(String("/native/path1"), fileInput->files()->item(0)->path());
@@ -98,8 +99,8 @@ TEST(FileInputTypeTest, setFilesFromPaths) {
// Try to upload multiple files with multipleAttr
input->setBooleanAttribute(HTMLNames::multipleAttr, true);
paths.clear();
- paths.append("/native/real/path1");
- paths.append("/native/real/path2");
+ paths.push_back("/native/real/path1");
+ paths.push_back("/native/real/path2");
fileInput->setFilesFromPaths(paths);
ASSERT_EQ(2u, fileInput->files()->length());
EXPECT_EQ(String("/native/real/path1"), fileInput->files()->item(0)->path());

Powered by Google App Engine
This is Rietveld 408576698