third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp - Issue 2583233002: Migrate WTF::Vector::append() to ::push_back() [part 7 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

Issue 2583233002: Migrate WTF::Vector::append() to ::push_back() [part 7 of N] (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

index 93f9bd0c73704062942564dfc2d81928378cf7c8..b47ce43e6e074350f79457220f9c66134af02b09 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

@@ -471,7 +471,7 @@ void HTMLTextAreaElement::setDefaultValue(const String& defaultValue) {

HeapVector<Member<Node>> textNodes;

for (Node* n = firstChild(); n; n = n->nextSibling()) {

if (n->isTextNode())

- textNodes.append(n);

+ textNodes.push_back(n);

}

for (const auto& text : textNodes)

removeChild(text.get(), IGNORE_EXCEPTION);