Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

Issue 2583233002: Migrate WTF::Vector::append() to ::push_back() [part 7 of N] (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp b/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
index 9b3667db4df7eb158dd0f786148a46e528ad268d..f52ece698b952bc35de1820910055a0d579b7cd5 100644
--- a/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
@@ -140,8 +140,8 @@ static void mapDataParamToSrc(Vector<String>* paramNames,
}
if (srcIndex == -1 && dataIndex != -1) {
- paramNames->append("src");
- paramValues->append((*paramValues)[dataIndex]);
+ paramNames->push_back("src");
+ paramValues->push_back((*paramValues)[dataIndex]);
}
}
@@ -163,8 +163,8 @@ void HTMLObjectElement::parametersForPlugin(Vector<String>& paramNames,
continue;
uniqueParamNames.add(name.impl());
- paramNames.append(p->name());
- paramValues.append(p->value());
+ paramNames.push_back(p->name());
+ paramValues.push_back(p->value());
// TODO(schenney): crbug.com/572908 url adjustment does not belong in this
// function.
@@ -201,8 +201,8 @@ void HTMLObjectElement::parametersForPlugin(Vector<String>& paramNames,
for (const Attribute& attribute : attributes) {
const AtomicString& name = attribute.name().localName();
if (!uniqueParamNames.contains(name.impl())) {
- paramNames.append(name.getString());
- paramValues.append(attribute.value().getString());
+ paramNames.push_back(name.getString());
+ paramValues.push_back(attribute.value().getString());
}
}
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMetaElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698