Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp

Issue 2583233002: Migrate WTF::Vector::append() to ::push_back() [part 7 of N] (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2011 Apple Inc. All rights 5 * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2011 Apple Inc. All rights
6 * reserved. 6 * reserved.
7 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 7 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 } 128 }
129 } else { 129 } else {
130 HTMLPlugInElement::parseAttribute(name, oldValue, value); 130 HTMLPlugInElement::parseAttribute(name, oldValue, value);
131 } 131 }
132 } 132 }
133 133
134 void HTMLEmbedElement::parametersForPlugin(Vector<String>& paramNames, 134 void HTMLEmbedElement::parametersForPlugin(Vector<String>& paramNames,
135 Vector<String>& paramValues) { 135 Vector<String>& paramValues) {
136 AttributeCollection attributes = this->attributes(); 136 AttributeCollection attributes = this->attributes();
137 for (const Attribute& attribute : attributes) { 137 for (const Attribute& attribute : attributes) {
138 paramNames.append(attribute.localName().getString()); 138 paramNames.push_back(attribute.localName().getString());
139 paramValues.append(attribute.value().getString()); 139 paramValues.push_back(attribute.value().getString());
140 } 140 }
141 } 141 }
142 142
143 // FIXME: This should be unified with HTMLObjectElement::updateWidget and 143 // FIXME: This should be unified with HTMLObjectElement::updateWidget and
144 // moved down into HTMLPluginElement.cpp 144 // moved down into HTMLPluginElement.cpp
145 void HTMLEmbedElement::updateWidgetInternal() { 145 void HTMLEmbedElement::updateWidgetInternal() {
146 DCHECK(!layoutEmbeddedItem().showsUnavailablePluginIndicator()); 146 DCHECK(!layoutEmbeddedItem().showsUnavailablePluginIndicator());
147 DCHECK(needsWidgetUpdate()); 147 DCHECK(needsWidgetUpdate());
148 setNeedsWidgetUpdate(false); 148 setNeedsWidgetUpdate(false);
149 149
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 for (HTMLObjectElement* object = 225 for (HTMLObjectElement* object =
226 Traversal<HTMLObjectElement>::firstAncestor(*this); 226 Traversal<HTMLObjectElement>::firstAncestor(*this);
227 object; object = Traversal<HTMLObjectElement>::firstAncestor(*object)) { 227 object; object = Traversal<HTMLObjectElement>::firstAncestor(*object)) {
228 if (object->isExposed()) 228 if (object->isExposed())
229 return false; 229 return false;
230 } 230 }
231 return true; 231 return true;
232 } 232 }
233 233
234 } // namespace blink 234 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698