Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1679)

Unified Diff: base/debug/activity_tracker.h

Issue 2583223002: Collect stability data from global and activity scopes (Closed)
Patch Set: signed/unsigned fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/debug/activity_tracker.h
diff --git a/base/debug/activity_tracker.h b/base/debug/activity_tracker.h
index 789905e288ae980b241977dae9fb7ac6d285e7ab..3077ea82b6b3f58e8a3ffe4dc8f9352fd0ecbaf9 100644
--- a/base/debug/activity_tracker.h
+++ b/base/debug/activity_tracker.h
@@ -132,7 +132,7 @@ extern const ActivityData kNullActivityData;
// A helper class that is used for managing memory allocations within a
// persistent memory allocator. Instances of this class are NOT thread-safe.
// Use from a single thread or protect access with a lock.
-class ActivityTrackerMemoryAllocator {
+class BASE_EXPORT ActivityTrackerMemoryAllocator {
public:
using Reference = PersistentMemoryAllocator::Reference;
@@ -307,6 +307,8 @@ class BASE_EXPORT ActivityUserData {
TypedValue(const TypedValue& other);
~TypedValue();
+ ValueType get_type() const { return type; }
bcwhite 2016/12/22 17:21:58 Just type(). Can't believe I forgot that one. :-O
manzagop (departed) 2017/01/10 14:11:22 Done. I switched to type() and renamed the variabl
+
// These methods return the extracted value in the correct format.
StringPiece Get() const;
StringPiece GetString() const;
@@ -537,6 +539,7 @@ class BASE_EXPORT ThreadActivityTracker {
// An identifier that indicates a specific activity on the stack.
ActivityId activity_id_;
+ private:
DISALLOW_COPY_AND_ASSIGN(ScopedActivity);
};
« no previous file with comments | « no previous file | base/debug/activity_tracker.cc » ('j') | components/browser_watcher/postmortem_report_collector.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698