Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Issue 2583083002: Early return in {Suspend,Resume}Renderer() if not backgrounded (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
index e7adcd74026afec69613dbf018d5068c9f904aaf..9abf01c8d01df2660217c29e6dfc24c503fac500 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
@@ -549,9 +549,10 @@ void RendererSchedulerImpl::OnAudioStateChanged() {
void RendererSchedulerImpl::SuspendRenderer() {
helper_.CheckOnValidThread();
- DCHECK(MainThreadOnly().renderer_backgrounded);
if (helper_.IsShutdown())
return;
+ if (!MainThreadOnly().renderer_backgrounded)
+ return;
suspend_timers_when_backgrounded_closure_.Cancel();
UMA_HISTOGRAM_COUNTS("PurgeAndSuspend.PendingTaskCount",
@@ -565,9 +566,10 @@ void RendererSchedulerImpl::SuspendRenderer() {
void RendererSchedulerImpl::ResumeRenderer() {
helper_.CheckOnValidThread();
- DCHECK(MainThreadOnly().renderer_backgrounded);
if (helper_.IsShutdown())
return;
+ if (!MainThreadOnly().renderer_backgrounded)
+ return;
suspend_timers_when_backgrounded_closure_.Cancel();
MainThreadOnly().renderer_suspended = false;
ResumeTimerQueueWhenForegroundedOrResumed();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698