Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 258293002: Remove unused GraphicsContext::drawEllipse() (Closed)

Created:
6 years, 7 months ago by f(malita)
Modified:
6 years, 7 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, rwlbuis
Visibility:
Public.

Description

Remove unused GraphicsContext::drawEllipse() Also update the GC unit test with explicit {fill|stroke}Ellipse calls to preserve current test semantics. R=senorblanco@chromium.org,schenney@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19 lines) Patch
M Source/platform/graphics/GraphicsContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/platform/graphics/GraphicsContextTest.cpp View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
f(malita)
6 years, 7 months ago (2014-04-29 15:53:45 UTC) #1
pdr.
On 2014/04/29 15:53:45, Florin Malita wrote: LGTM
6 years, 7 months ago (2014-04-29 15:57:16 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 7 months ago (2014-04-29 15:57:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/258293002/1
6 years, 7 months ago (2014-04-29 15:57:32 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 22:39:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink
6 years, 7 months ago (2014-04-29 22:39:54 UTC) #6
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 7 months ago (2014-04-30 12:25:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/258293002/1
6 years, 7 months ago (2014-04-30 12:25:36 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 14:47:59 UTC) #9
Message was sent while issue was closed.
Change committed as 172978

Powered by Google App Engine
This is Rietveld 408576698