Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/foreign-fetch-basics.html

Issue 2582833002: Fix foreign fetch intercepting CORS preflighted requests if preflight was in cache. (Closed)
Patch Set: address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/foreign-fetch-basics.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/foreign-fetch-basics.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/foreign-fetch-basics.html
index 99ccacdc784684b24267e6bcf12d6bdfed27d0fd..6bd8c5abf3f28b5b070d391173808c9c0898056f 100644
--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/foreign-fetch-basics.html
+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/foreign-fetch-basics.html
@@ -236,6 +236,10 @@ promise_test(t => {
return install_cross_origin_worker(t, worker_for_scopes(['']), scope)
.then(() => fetch(remote_url, {method: 'SPECIAL'}))
.then(response => response.text())
+ .then(response_text => assert_true(response_text.startsWith('report(')))
+ // Do the whole thing twice to test CORS preflight cache behavior.
+ .then(() => fetch(remote_url, {method: 'SPECIAL'}))
+ .then(response => response.text())
.then(response_text => assert_true(response_text.startsWith('report(')));
}, 'Service Worker does not intercept fetches with CORS preflight');
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698