Fix foreign fetch intercepting CORS preflighted requests if preflight was in cache.

third_party/WebKit/LayoutTests/http/tests/serviceworker/foreign-fetch-basics.html

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/foreign-fetch-basics.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/foreign-fetch-basics.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/foreign-fetch-basics.html
index 99ccacdc784684b24267e6bcf12d6bdfed27d0fd..6bd8c5abf3f28b5b070d391173808c9c0898056f 100644
--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/foreign-fetch-basics.html
+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/foreign-fetch-basics.html
@@ -236,6 +236,10 @@ promise_test(t => {
     return install_cross_origin_worker(t, worker_for_scopes(['']), scope)
       .then(() => fetch(remote_url, {method: 'SPECIAL'}))
       .then(response => response.text())
+      .then(response_text => assert_true(response_text.startsWith('report(')))
+      // Do the whole thing twice to test CORS preflight cache behavior.
+      .then(() => fetch(remote_url, {method: 'SPECIAL'}))

[yhirano, 2016/12/20 07:42:26]

Isn't it better to have two separate tests?

[Marijn Kruisselbrink, 2016/12/20 17:28:28]

I don't think so. I don't like having dependencies between tests (even if the
tests are in the same file/are guaranteed by promise_test to be run in order). I
think it's much clearer to just have all this in the same test.
(unless you meant have two tests, one that just does a cors-preflighted fetch
once as before, and one that does the exact same thing twice as this test does
now (but both with different SW scopes to avoid any chance of dependency between
the two). I support I could do that, but the benefit of that seems rather
small).

+      .then(response => response.text())
       .then(response_text => assert_true(response_text.startsWith('report(')));
   }, 'Service Worker does not intercept fetches with CORS preflight');