Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Unified Diff: chrome/browser/ui/cocoa/profiles/user_manager_mac.mm

Issue 2582793003: Fix user manager window's rounded corners by ensuring its content view is layer backed. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/profiles/user_manager_mac.mm
diff --git a/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm b/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm
index 261283b4dcd82ad7822c5c49297551310e1ac207..5f850aed19f01b36cfe26374433a62b30371ca82 100644
--- a/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm
+++ b/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm
@@ -316,6 +316,14 @@ class UserManagerProfileDialogDelegate
webContents_.reset(content::WebContents::Create(
content::WebContents::CreateParams(profile)));
window.contentView = webContents_->GetNativeView();
+
+ // When a window has layer-backed subviews, its contentView must be
+ // layer-backed or it won't mask the subviews to its rounded corners. See
+ // https://crbug.com/620049
+ // The static_cast is just needed for the 10.10 SDK. It can be removed when
+ // we move to a newer one.
+ static_cast<NSView*>(window.contentView).wantsLayer = YES;
+
webContentsDelegate_.reset(new UserManagerWebContentsDelegate());
webContents_->SetDelegate(webContentsDelegate_.get());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698