Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2582753003: Fix analysis.getNavigation with the new analysis driver. (Closed)

Created:
4 years ago by scheglov
Modified:
4 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -43 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/new_notifications.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 3 chunks +30 lines, -18 lines 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart View 2 chunks +19 lines, -24 lines 0 comments Download
M pkg/analysis_server/test/analysis/get_navigation_test.dart View 2 chunks +11 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 3 chunks +7 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years ago (2016-12-16 18:38:20 UTC) #1
Brian Wilkerson
lgtm
4 years ago (2016-12-16 18:42:59 UTC) #2
scheglov
4 years ago (2016-12-16 18:52:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eaca15cd4da4ac93ac26c5dc9b5b36a9138a5362 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698