Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8515)

Unified Diff: chrome/test/BUILD.gn

Issue 2582743002: Remove obsolete app_list Linux code. (Closed)
Patch Set: Remove more things. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index ba93142fd4b616889bcd3b50aa8ba0c41c737ebc..c66b401561632e951beb1488ee6344a02aebf44d 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -2553,16 +2553,9 @@ test("browser_tests") {
"../browser/apps/drive/drive_app_provider_browsertest.cc",
"../browser/ui/app_list/app_list_controller_browsertest.cc",
tapted 2016/12/16 05:11:41 There are some #if (OS_CHROMEOS) in here
Matt Giuca 2016/12/21 06:18:03 Done.
"../browser/ui/app_list/app_list_service_impl_browsertest.cc",
tapted 2016/12/16 05:11:41 There are lots (more) #if (OS_CHROMEOS) in this f
Matt Giuca 2016/12/21 06:18:03 Done.
- "../browser/ui/app_list/app_list_service_views_browsertest.cc",
"../browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc",
"../browser/ui/app_list/speech_recognizer_browsertest.cc",
]
- if (is_mac) {
- # This assumes the AppList is views-based, but Mac only links
- # browser parts for the Cocoa implementation.
- sources -=
- [ "../browser/ui/app_list/app_list_service_views_browsertest.cc" ]
- }
}
if (enable_service_discovery) {
sources += [ "../browser/extensions/api/mdns/mdns_apitest.cc" ]
@@ -4832,7 +4825,6 @@ test("unit_tests") {
sources += [
"../browser/apps/drive/drive_app_mapping_unittest.cc",
"../browser/ui/app_list/app_context_menu_unittest.cc",
- "../browser/ui/app_list/app_list_positioner_unittest.cc",
"../browser/ui/app_list/app_list_service_unittest.cc",
tapted 2016/12/16 05:11:41 This has some profile switching stuff that will pr
Matt Giuca 2016/12/21 06:18:03 Acknowledged.
"../browser/ui/app_list/app_list_test_util.cc",
"../browser/ui/app_list/app_list_test_util.h",
@@ -4847,8 +4839,6 @@ test("unit_tests") {
"../browser/ui/app_list/test/fake_profile.h",
"../browser/ui/app_list/test/fake_profile_store.cc",
"../browser/ui/app_list/test/fake_profile_store.h",
tapted 2016/12/16 05:11:41 All the fake_profile goop probably isn't needed ei
Matt Giuca 2016/12/21 06:18:03 Acknowledged.
- "../browser/ui/app_list/test/fast_show_pickler_unittest.cc",
- "../browser/ui/views/app_list/linux/app_list_linux_unittest.cc",
]
deps += [ "//ui/app_list:test_support" ]
}
@@ -4860,8 +4850,6 @@ test("unit_tests") {
"../browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc",
"../browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc",
]
- sources -=
- [ "../browser/ui/views/app_list/linux/app_list_linux_unittest.cc" ]
deps += [ "//components/arc:arc_test_support" ]
}
if (enable_plugins && !enable_plugin_installation) {

Powered by Google App Engine
This is Rietveld 408576698