Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2582733003: Disable dependency_grapher_test on dart2js for now. (Closed)

Created:
4 years ago by Paul Berry
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disable dependency_grapher_test on dart2js for now. The test has a transitive dependency on dart:io which I haven't quite figured out yet. Once I figure out how to remove the transitive dependency I'll re-enable the test. TBR=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/f4e5c95606e9ba7c0bdcea8531cd5f0b1bcba095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/pkg.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Paul Berry
Committed patchset #1 (id:1) manually as f4e5c95606e9ba7c0bdcea8531cd5f0b1bcba095 (presubmit successful).
4 years ago (2016-12-16 05:36:25 UTC) #2
Siggi Cherem (dart-lang)
4 years ago (2016-12-16 16:33:08 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698