Cut and Copy option should not be avilable for password field.

Cut and Copy option should not be avilable for password field.

For now cut and copy option appears on selection text in
password field but no operation happens when user taps on cut
or copy from the action bar appeared at the top
So removing the cut and copy is selection happens on password
field.

BUG=368174
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270369

[ankit, 2014-04-30 03:13:26]

PTAL

[jdduke (slow), 2014-04-30 14:54:50]

Looks good, but aurimas@ is a better reviewer for this.

https://codereview.chromium.org/258273002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java
(right):

https://codereview.chromium.org/258273002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java:76:
* @return true is the current selection is of password type.
|true is| -> |Whether| or |true iff|

Maybe we should call this |isSelectionPassword()| to parallel
|isSelectionEditable()|? In that case, let's move this below the
|isSelectionEditable()| method.

https://codereview.chromium.org/258273002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
(right):

https://codereview.chromium.org/258273002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:497:
public boolean isPasswordType() {
I realize other public methods in this class lack comments, but please add a
brief Javadoc and move this method up below the other public member
|hasTextInputType()|.

[Ted C, 2014-04-30 16:09:48]

https://codereview.chromium.org/258273002/diff/1/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/258273002/diff/1/AUTHORS#newcode37
AUTHORS:37: Ankit Kumar <ankit2.kumar@samsung.com>
Unfortunately, you are not listed in the CLA for Samsung, so you will need to be
added to the list before we can approve changes from you.

http://dev.chromium.org/developers/contributing-code/external-contributor-che...

[ankit, 2014-05-02 09:05:15]

PTAL new patch set

[ankit, 2014-05-05 03:32:35]

@aurimas PTAL new patch set

[aurimas (slooooooooow), 2014-05-05 03:58:27]

On 2014/05/05 03:32:35, ankit2.kumar wrote:
> @aurimas PTAL new patch set

It still looks like you haven't responded to tedchoc's comment about CLA. Please
do that first and then I will review your patch.

[ankit, 2014-05-12 03:54:18]

@aurimas 
Name added to list in CLA for Samsung. PTAL

[aurimas (slooooooooow), 2014-05-12 17:44:33]

lgtm

[ankit, 2014-05-13 05:32:04]

The CQ bit was checked by ankit2.kumar@samsung.com

[commit-bot: I haz the power, 2014-05-13 05:32:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/258273002/20001

[commit-bot: I haz the power, 2014-05-13 06:28:13]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-13 06:32:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-13 06:32:21]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[ankit, 2014-05-13 09:09:04]

PTAL

[Ted C, 2014-05-13 17:36:57]

On 2014/05/13 09:09:04, ankit2.kumar wrote:
> PTAL

I still do not see your name listed in:
https://docs.google.com/a/google.com/spreadsheet/lv?hl=en&key=0AjutNIkpUHk2cD...

I'm trying to figure out if there is a delay and what is the correct
way to resolve this.  Sorry about the hold up.

[Ted C, 2014-05-14 00:53:58]

On 2014/05/13 17:36:57, Ted C wrote:
> On 2014/05/13 09:09:04, ankit2.kumar wrote:
> > PTAL
> 
> I still do not see your name listed in:
>
https://docs.google.com/a/google.com/spreadsheet/lv?hl=en&key=0AjutNIkpUHk2cD...
> 
> I'm trying to figure out if there is a delay and what is the correct
> way to resolve this.  Sorry about the hold up.

And it got updated, lgtm!

[ankit, 2014-05-14 03:46:23]

The CQ bit was checked by ankit2.kumar@samsung.com

[commit-bot: I haz the power, 2014-05-14 03:47:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/258273002/30001

[commit-bot: I haz the power, 2014-05-14 06:47:29]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-14 10:01:50]

Change committed as 270369