[USS] Impelementation for GetData and GetAllData

components/autofill/core/browser/webdata/autocomplete_sync_bridge.h

Index: components/autofill/core/browser/webdata/autocomplete_sync_bridge.h
diff --git a/components/autofill/core/browser/webdata/autocomplete_sync_bridge.h b/components/autofill/core/browser/webdata/autocomplete_sync_bridge.h
index 2a575ed9c500f213ce8c329f1b027c75c18a2bd2..d45b1ae2d74bb5ae5d5be5ef5275ca71c619282e 100644
--- a/components/autofill/core/browser/webdata/autocomplete_sync_bridge.h
+++ b/components/autofill/core/browser/webdata/autocomplete_sync_bridge.h
@@ -65,9 +65,20 @@ class AutocompleteSyncBridge : public base::SupportsUserData::Data,
   void AutofillEntriesChanged(const AutofillChangeList& changes) override;
 
  private:
+  friend class AutocompleteSyncBridgeTest;

[vabr (Chromium), 2016/12/21 08:48:07]

Please do not friend the test. Tests should only depend on the public API,
making them depend on the internals makes them fragile. I added some concrete
suggestions below for how to keep your current test without the need to friend
it with the bridge.

[Gang Wu, 2016/12/22 01:33:53]

Done.

+
   // Returns the table associated with the |web_data_backend_|.
   AutofillTable* GetAutofillTable() const;
 
+  std::string GetStorageKeyFromAutofillEntry(
+      const autofill::AutofillEntry& entry);
+
+  static std::string FormatStorageKey(const std::string& name,
+                                      const std::string& value);
+
+  static AutofillEntry CreateAutofillEntry(

[vabr (Chromium), 2016/12/21 08:48:07]

I can only see this used in the test. Could you define it as an anonymous
function there?

[skym, 2016/12/21 21:50:41]

I think moving this function to the test file would be short sighted. We're
going to need this function for the bridge implementation. Maybe this could
simply be public instead of private? I don't think it would hurt to unittest
this function directly. I think converting between specifics and AutofillEntry
and/or AutofillKey objects is essentially core functionality the bridge
performs.

[Gang Wu, 2016/12/22 01:33:53]

you are right, we need this function later on, even I move this one to unittest,
we will move it back when sync data from sync server to autofill. So change it
to public.

[Gang Wu, 2016/12/22 01:33:53]

Done.

+      const sync_pb::AutofillSpecifics& autofill_specifics);
+
   base::ThreadChecker thread_checker_;
 
   // AutocompleteSyncBridge is owned by |web_data_backend_| through