Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: media/audio/audio_manager.cc

Issue 2582703003: Audio output debug recording. (Closed)
Patch Set: Code review (dalecurtis@ and maxmorin@). Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_manager.cc
diff --git a/media/audio/audio_manager.cc b/media/audio/audio_manager.cc
index 30430bf58fad74f6e48e5dce5a7c851183777868..be1cd2c1f860fbd6e385a63ed5a6f4845d1cb4ba 100644
--- a/media/audio/audio_manager.cc
+++ b/media/audio/audio_manager.cc
@@ -45,6 +45,12 @@ AudioManager* g_last_created = nullptr;
// suspends before a OnSuspend() event can be fired).
const int kMaxFailedPingsCount = 3;
+// Dummy function for creating debug writer.
+std::unique_ptr<AudioFileWriter> CreateAudioFileWriterDummy(
+ const AudioParameters& params) {
+ return nullptr;
+}
+
// Helper class for managing global AudioManager data and hang monitor. If the
// audio thread is hung for > |kMaxFailedPingsCount| * |max_hung_task_time_|, we
// want to record a UMA and optionally a non-crash dump to find offenders in the
@@ -301,7 +307,8 @@ void AudioManagerDeleter::operator()(const AudioManager* instance) const {
ScopedAudioManagerPtr CreateAudioManager(
scoped_refptr<base::SingleThreadTaskRunner> task_runner,
scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner,
- AudioLogFactory* audio_log_factory);
+ AudioLogFactory* audio_log_factory,
+ CreateAudioFileWriterCallback create_audio_file_writer_callback);
void AudioManager::SetMaxStreamCountForTesting(int max_input, int max_output) {
NOTREACHED();
@@ -333,11 +340,13 @@ AudioManager::~AudioManager() {
ScopedAudioManagerPtr AudioManager::Create(
scoped_refptr<base::SingleThreadTaskRunner> task_runner,
scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner,
- AudioLogFactory* audio_log_factory) {
+ AudioLogFactory* audio_log_factory,
+ CreateAudioFileWriterCallback create_audio_file_writer_callback) {
DCHECK(task_runner);
DCHECK(worker_task_runner);
return CreateAudioManager(std::move(task_runner),
- std::move(worker_task_runner), audio_log_factory);
+ std::move(worker_task_runner), audio_log_factory,
+ std::move(create_audio_file_writer_callback));
}
// static
@@ -347,7 +356,8 @@ ScopedAudioManagerPtr AudioManager::CreateForTesting(
g_helper.Pointer()->InitializeCOMForTesting();
#endif
return Create(task_runner, task_runner,
- g_helper.Pointer()->fake_log_factory());
+ g_helper.Pointer()->fake_log_factory(),
+ base::Bind(&CreateAudioFileWriterDummy));
}
// static

Powered by Google App Engine
This is Rietveld 408576698