Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: media/audio/audio_debug_file_writer_unittest.cc

Issue 2582703003: Audio output debug recording. (Closed)
Patch Set: Code review. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/audio_debug_file_writer.cc ('k') | media/audio/audio_debug_recording_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_debug_file_writer_unittest.cc
diff --git a/media/audio/audio_debug_file_writer_unittest.cc b/media/audio/audio_debug_file_writer_unittest.cc
index 4b6f2b883c4859abec4381be2690a1502cc4f125..ce3f3e87ad239d9ae0afba1e76f5f1b062d6ffd7 100644
--- a/media/audio/audio_debug_file_writer_unittest.cc
+++ b/media/audio/audio_debug_file_writer_unittest.cc
@@ -13,6 +13,7 @@
#include "base/threading/thread.h"
#include "media/audio/audio_debug_file_writer.h"
#include "media/base/audio_bus.h"
+#include "media/base/audio_sample_types.h"
#include "media/base/test_helpers.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -167,10 +168,10 @@ class AudioDebugFileWriterTest
std::unique_ptr<AudioBus> bus =
AudioBus::Create(params_.channels(), params_.frames_per_buffer());
- bus->FromInterleaved(
+ bus->FromInterleaved<media::SignedInt16SampleTypeTraits>(
source_interleaved_.get() +
i * params_.channels() * params_.frames_per_buffer(),
- params_.frames_per_buffer(), kBytesPerSample);
+ params_.frames_per_buffer());
debug_writer_->Write(std::move(bus));
}
@@ -244,10 +245,16 @@ class AudioDebugFileWriterBehavioralTest : public AudioDebugFileWriterTest {};
TEST_P(AudioDebugFileWriterTest, WaveRecordingTest) {
debug_writer_.reset(
new AudioDebugFileWriter(params_, file_thread_.task_runner()));
-
RecordAndVerifyOnce();
}
+TEST_P(AudioDebugFileWriterTest, GetFileNameExtension) {
+ debug_writer_.reset(
+ new AudioDebugFileWriter(params_, file_thread_.task_runner()));
+ EXPECT_EQ(FILE_PATH_LITERAL("wav"),
+ base::FilePath::StringType(debug_writer_->GetFileNameExtension()));
+}
+
TEST_P(AudioDebugFileWriterBehavioralTest,
DeletedBeforeRecordingFinishedOnFileThread) {
debug_writer_.reset(
« no previous file with comments | « media/audio/audio_debug_file_writer.cc ('k') | media/audio/audio_debug_recording_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698