Audio output debug recording.

media/audio/audio_manager_base.h

Index: media/audio/audio_manager_base.h
diff --git a/media/audio/audio_manager_base.h b/media/audio/audio_manager_base.h
index b3100cf6c507bb6cb6af2086806356cc3c6de15a..21f82802b96f859fff064eeb6a9a94d4a027d358 100644
--- a/media/audio/audio_manager_base.h
+++ b/media/audio/audio_manager_base.h
@@ -16,6 +16,7 @@
 #include "base/observer_list.h"
 #include "base/threading/thread.h"
 #include "build/build_config.h"
+#include "media/audio/audio_debug_recording_manager.h"
 #include "media/audio/audio_device_name.h"
 #include "media/audio/audio_manager.h"
 #include "media/audio/audio_output_dispatcher.h"
@@ -24,6 +25,10 @@
 #include "base/win/scoped_com_initializer.h"
 #endif
 
+namespace base {
+class FilePath;
+}
+
 namespace media {
 
 class AudioOutputDispatcher;
@@ -67,6 +72,11 @@ class MEDIA_EXPORT AudioManagerBase : public AudioManager {
       const std::string& input_device_id) override;
   std::unique_ptr<AudioLog> CreateAudioLog(
       AudioLogFactory::AudioComponent component) override;
+  void InitializeOutputDebugRecording(
+      CreateAudioFileWriterCallback create_audio_file_writer_callback) override;
+  void EnableOutputDebugRecording(
+      const base::FilePath& base_file_name) override;
+  void DisableOutputDebugRecording() override;
 
   void SetMaxStreamCountForTesting(int max_input, int max_output) final;
 
@@ -189,6 +199,9 @@ class MEDIA_EXPORT AudioManagerBase : public AudioManager {
   // Proxy for creating AudioLog objects.
   AudioLogFactory* const audio_log_factory_;
 
+  // Debug recording manager.
+  std::unique_ptr<AudioDebugRecordingManager> output_debug_recording_manager_;

[o1ka, 2017/01/31 11:00:11]

Why calling it "output"? Won't it work for inputs just as well?

[Henrik Grunell, 2017/02/08 11:29:38]

Good point. The "output" filename extension is given in the constructor, global
for the recording manager, but I changed it to be given per stream instead. In
the future, apart from input we'll likely also want output recording at another
point with another extension.

One effect of this, just to be aware of, is that the unique running ID will be
global for all these streams. I think that's fine.

So, after that change, I also changed this variable. However, I think it makes
sense to keep the naming of functions above since it currently only controls
output.

+
   DISALLOW_COPY_AND_ASSIGN(AudioManagerBase);
 };