Audio output debug recording.

media/audio/audio_manager.h

Index: media/audio/audio_manager.h
diff --git a/media/audio/audio_manager.h b/media/audio/audio_manager.h
index c5a7cdd949b96f912b1ca50aca03da4439bae293..59ae7c50cc0e76c9959e84ac1b78b2510ac8a2b2 100644
--- a/media/audio/audio_manager.h
+++ b/media/audio/audio_manager.h
@@ -15,6 +15,7 @@
 #include "base/strings/string16.h"
 #include "build/build_config.h"
 #include "media/audio/audio_device_description.h"
+#include "media/audio/audio_file_writer.h"
 #include "media/audio/audio_logging.h"
 #include "media/base/audio_parameters.h"
 
@@ -63,7 +64,8 @@ class MEDIA_EXPORT AudioManager {
   static ScopedAudioManagerPtr Create(
       scoped_refptr<base::SingleThreadTaskRunner> task_runner,
       scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner,
-      AudioLogFactory* audio_log_factory);
+      AudioLogFactory* audio_log_factory,
+      CreateAudioFileWriterCallback create_audio_file_writer_callback);

[DaleCurtis, 2017/01/26 17:53:18]

Do you really need to inject this here? This causes complexity for all
AudioManager implementations for something that can be handled in the base
implementation.

[Henrik Grunell, 2017/01/26 19:56:22]

I know, it's annoying. The content layer passes the callback, that's why. And
the reason for writer implementation not being in media is that it handles file
writing afaik. Any suggestions to avoid this?

[DaleCurtis, 2017/01/26 20:00:13]

Just make the caller of Enable() deal with it? That code is already in content.
Doesn't seem to be any reason it couldn't be passed in every time.

[o1ka, 2017/01/27 09:25:26]

This is a pretty neat idea.

[Henrik Grunell, 2017/01/27 16:07:23]

You're right, that would work since the create callback is not used until
enabling. However, it's also enabled from chrome/ where the create function is
not available. Instead I added an init function that sets the callback and call
this after creating.

 
   // A convenience wrapper of AudioManager::Create for testing.
   // The given |task_runner| is shared for both audio io and heavyweight tasks.
@@ -248,6 +250,14 @@ class MEDIA_EXPORT AudioManager {
   virtual std::unique_ptr<AudioLog> CreateAudioLog(
       AudioLogFactory::AudioComponent component) = 0;
 
+  // Enable output debug recording.
+  // TODO(grunell): Control input debug recording via these functions too.
+  virtual void EnableOutputDebugRecording(
+      const base::FilePath& base_file_name) = 0;
+
+  // Disable output debug recording.
+  virtual void DisableOutputDebugRecording() = 0;
+
   // Gets the name of the audio manager (e.g., Windows, Mac, PulseAudio).
   virtual const char* GetName() = 0;