Audio output debug recording.

content/browser/browser_main_loop.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_main_loop.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <utility>
@@ skipping 50 matching lines @@
 #include "content/browser/gpu/gpu_data_manager_impl.h"
 #include "content/browser/gpu/gpu_process_host.h"
 #include "content/browser/gpu/gpu_process_host_ui_shim.h"
 #include "content/browser/gpu/shader_cache_factory.h"
 #include "content/browser/histogram_synchronizer.h"
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
 #include "content/browser/loader_delegate_impl.h"
 #include "content/browser/media/media_internals.h"
 #include "content/browser/memory/memory_coordinator_impl.h"
 #include "content/browser/net/browser_online_state_observer.h"
+#include "content/browser/renderer_host/media/audio_debug_file_writer.h"
 #include "content/browser/renderer_host/media/media_stream_manager.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/service_manager/service_manager_context.h"
 #include "content/browser/speech/speech_recognition_manager_impl.h"
 #include "content/browser/startup_task_runner.h"
 #include "content/browser/utility_process_host_impl.h"
 #include "content/browser/webui/content_web_ui_controller_factory.h"
 #include "content/browser/webui/url_data_manager.h"
 #include "content/common/content_switches_internal.h"
 #include "content/common/host_shared_bitmap_manager.h"
@@ skipping 1707 matching lines @@
   DCHECK(!audio_thread_);
   DCHECK(!audio_manager_);
 
   audio_manager_ = GetContentClient()->browser()->CreateAudioManager(
       MediaInternals::GetInstance());
   if (!audio_manager_) {
     audio_thread_ = base::MakeUnique<AudioManagerThread>();
     audio_manager_ = media::AudioManager::Create(
         audio_thread_->task_runner(), audio_thread_->worker_task_runner(),
         MediaInternals::GetInstance());
+#if BUILDFLAG(ENABLE_WEBRTC)
+    // AudioManager is deleted on the audio thread, so it's safe to post
+    // unretained.
+    audio_manager_->GetTaskRunner()->PostTask(

[pfeldman, 2017/02/14 19:44:28]

Why is this here, but not in the  media::AudioManager::Create?

[Henrik Grunell, 2017/02/14 20:22:17]

That's a good point. There was a discussion earlier in the code review to avoid
passing the callback to the ctor, but it should be possible to move this post in
AM::Create(). I don't see any problem doing that.

Dale: wdyt about that? It would add one parameter to AM::Create (only).

[DaleCurtis, 2017/02/14 20:30:29]

Don't want this added as a parameter; instead I'd argue that
InitializeOutputDebugRecording() should PostTask if on the wrong thread.

[Henrik Grunell, 2017/02/15 11:45:11]

That sounds like a reasonable option, I've changed to doing that.

pfeldman@ ptal.

+        FROM_HERE,
+        base::Bind(&media::AudioManager::InitializeOutputDebugRecording,
+                   base::Unretained(audio_manager_.get()),
+                   base::BindRepeating(&AudioDebugFileWriter::Create)));
+#endif
   }
   CHECK(audio_manager_);
 
   audio_system_ = media::AudioSystemImpl::Create(audio_manager_.get());
   CHECK(audio_system_);
 }
 
 }  // namespace content