Audio output debug recording.

media/audio/audio_manager_base.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/audio/audio_manager_base.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/macros.h"
@@ skipping 66 matching lines @@
 
 AudioManagerBase::AudioManagerBase(
     scoped_refptr<base::SingleThreadTaskRunner> task_runner,
     scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner,
     AudioLogFactory* audio_log_factory)
     : AudioManager(std::move(task_runner), std::move(worker_task_runner)),
       max_num_output_streams_(kDefaultMaxOutputStreams),
       max_num_input_streams_(kDefaultMaxInputStreams),
       num_output_streams_(0),
       // TODO(dalecurtis): Switch this to an base::ObserverListThreadSafe, so we
-      // don't
-      // block the UI thread when swapping devices.
+      // don't block the UI thread when swapping devices.
       output_listeners_(
           base::ObserverList<AudioDeviceListener>::NOTIFY_EXISTING_ONLY),
       audio_log_factory_(audio_log_factory) {}
 
 AudioManagerBase::~AudioManagerBase() {
   DCHECK(GetTaskRunner()->BelongsToCurrentThread());
 
   // All the output streams should have been deleted.
   CHECK_EQ(0, num_output_streams_);
   // All the input streams should have been deleted.
@@ skipping 179 matching lines @@
                    CompareByParams(dispatcher_params));
   if (it != output_dispatchers_.end()) {
     delete dispatcher_params;
     return (*it)->dispatcher->CreateStreamProxy();
   }
 
   const base::TimeDelta kCloseDelay =
       base::TimeDelta::FromSeconds(kStreamCloseDelaySeconds);
   std::unique_ptr<AudioOutputDispatcher> dispatcher;
   if (output_params.format() != AudioParameters::AUDIO_FAKE) {
+    // Using unretained is safe since |output_debug_recording_manager_|
+    // outlives the dispatchers (cleared in Shutdown()).
     dispatcher = base::MakeUnique<AudioOutputResampler>(
-        this, params, output_params, output_device_id, kCloseDelay);
+        this, params, output_params, output_device_id, kCloseDelay,
+        base::Bind(&AudioDebugRecordingManager::RegisterDebugRecordingSource,
+                   base::Unretained(output_debug_recording_manager_.get())));

[o1ka, 2017/01/31 11:00:11]

Check if |output_debug_recording_manager_| is initialized. otherwise pass a
no-op callback?

[Henrik Grunell, 2017/02/08 11:29:37]

Yes, done.

   } else {
     dispatcher = base::MakeUnique<AudioOutputDispatcherImpl>(
         this, output_params, output_device_id, kCloseDelay);
   }
 
   dispatcher_params->dispatcher = std::move(dispatcher);
   output_dispatchers_.push_back(dispatcher_params);
   return dispatcher_params->dispatcher->CreateStreamProxy();
 }
 
@@ skipping 126 matching lines @@
     return buffer_size;
 
   return 0;
 }
 
 std::unique_ptr<AudioLog> AudioManagerBase::CreateAudioLog(
     AudioLogFactory::AudioComponent component) {
   return audio_log_factory_->CreateAudioLog(component);
 }
 
+void AudioManagerBase::InitializeOutputDebugRecording(
+    CreateAudioFileWriterCallback create_audio_file_writer_callback) {
+  DCHECK(GetTaskRunner()->BelongsToCurrentThread());
+  DCHECK(!output_debug_recording_manager_);
+  output_debug_recording_manager_ =
+      base::MakeUnique<AudioDebugRecordingManager>(
+          create_audio_file_writer_callback, "output", GetTaskRunner());
+}
+
+void AudioManagerBase::EnableOutputDebugRecording(
+    const base::FilePath& base_file_name) {
+  DCHECK(GetTaskRunner()->BelongsToCurrentThread());
+  output_debug_recording_manager_->EnableDebugRecording(base_file_name);

[o1ka, 2017/01/31 11:00:11]

Check if |output_debug_recording_manager_| is initialized

[Henrik Grunell, 2017/02/08 11:29:37]

Enable() should not be called if Initialize() hasn't been called. Thus it should
be a DCHECK, which is redundant since it'll crash on deref.

+}
+
+void AudioManagerBase::DisableOutputDebugRecording() {
+  DCHECK(GetTaskRunner()->BelongsToCurrentThread());
+  if (output_debug_recording_manager_)
+    output_debug_recording_manager_->DisableDebugRecording();
+}
+
 void AudioManagerBase::SetMaxStreamCountForTesting(int max_input,
                                                    int max_output) {
   max_num_output_streams_ = max_output;
   max_num_input_streams_ = max_input;
 }
 
 }  // namespace media