Audio output debug recording.

media/audio/audio_debug_recording_manager.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "media/audio/audio_debug_recording_manager.h"
+
+#include "base/bind.h"
+#include "base/files/file_path.h"
+#include "base/memory/ptr_util.h"
+#include "base/single_thread_task_runner.h"
+#include "base/strings/string_number_conversions.h"
+#include "media/audio/audio_manager.h"
+
+namespace media {
+
+namespace {
+
+// Running id recording sources.
+int g_next_stream_id = 1;
+
+}  // namespace
+
+AudioDebugRecordingManager::AudioDebugRecordingManager(
+    CreateAudioFileWriterCallback create_audio_file_writer_callback,
+    const std::string& file_name_extension,
+    scoped_refptr<base::SingleThreadTaskRunner> task_runner)
+    : create_audio_file_writer_callback_(
+          std::move(create_audio_file_writer_callback)),
+      file_name_extension_(file_name_extension),
+      task_runner_(std::move(task_runner)) {
+  DCHECK(create_audio_file_writer_callback_);
+}
+
+AudioDebugRecordingManager::~AudioDebugRecordingManager() {}
+
+void AudioDebugRecordingManager::EnableDebugRecording(
+    const base::FilePath& base_file_name) {
+  DCHECK(task_runner_->BelongsToCurrentThread());
+  for (const auto& it : debug_recording_helpers_) {
+    it.second->EnableDebugRecording(
+        GetOutputDebugRecordingFileNameWithExtensions(base_file_name,
+                                                      it.first));
+  }
+  debug_recording_base_file_name_ = base_file_name;
+}
+
+void AudioDebugRecordingManager::DisableDebugRecording() {
+  DCHECK(task_runner_->BelongsToCurrentThread());
+  for (const auto& it : debug_recording_helpers_)
+    it.second->DisableDebugRecording();
+  debug_recording_base_file_name_.clear();
+}
+
+std::unique_ptr<AudioDebugRecorder>
+AudioDebugRecordingManager::RegisterDebugRecordingSource(
+    const AudioParameters& params) {
+  DCHECK(task_runner_->BelongsToCurrentThread());
+
+  const int id = g_next_stream_id++;
+
+  std::unique_ptr<AudioDebugRecordingHelper> recording_helper =
+      base::MakeUnique<AudioDebugRecordingHelper>(
+          params, create_audio_file_writer_callback_, task_runner_,
+          base::Bind(
+              &AudioDebugRecordingManager::UnregisterDebugRecordingSource,
+              base::Unretained(this), id));

[o1ka, 2017/01/31 11:00:11]

Please specify why Unretained() is safe.

[Henrik Grunell, 2017/02/08 11:29:37]

Changed it to use a weak pointer. Unretained() was safe since the manager
outlived the resampler, but to not require this I changed to weak ptr. Added
comment.

+
+  if (!debug_recording_base_file_name_.empty()) {

[o1ka, 2017/01/31 11:00:11]

Then you need to check it in Enable/Disbale() as well

[Henrik Grunell, 2017/02/08 11:29:37]

I'm not sure what you mean. Enable() takes the file name as an argument, I added
a DCHECK there which makes sense.

+    recording_helper->EnableDebugRecording(
+        GetOutputDebugRecordingFileNameWithExtensions(
+            debug_recording_base_file_name_, id));
+  }
+
+  debug_recording_helpers_[id] = recording_helper.get();
+
+  return recording_helper;
+}
+
+void AudioDebugRecordingManager::UnregisterDebugRecordingSource(int id) {
+  DCHECK(task_runner_->BelongsToCurrentThread());
+  auto it = debug_recording_helpers_.find(id);
+  DCHECK(it != debug_recording_helpers_.end());
+  debug_recording_helpers_.erase(id);
+}
+
+#if defined(OS_WIN)
+#define IntToStringType base::IntToString16
+#else
+#define IntToStringType base::IntToString
+#endif
+
+base::FilePath
+AudioDebugRecordingManager::GetOutputDebugRecordingFileNameWithExtensions(
+    const base::FilePath& file_name,
+    int id) {
+  DCHECK(task_runner_->BelongsToCurrentThread());
+  return file_name.AddExtension(file_name_extension_)
+      .AddExtension(IntToStringType(id));
+}
+
+}  // namespace media