Audio output debug recording.

media/audio/audio_output_resampler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_AUDIO_AUDIO_OUTPUT_RESAMPLER_H_
 #define MEDIA_AUDIO_AUDIO_OUTPUT_RESAMPLER_H_
 
 #include <map>
 
+#include "base/files/file_path.h"
 #include "base/macros.h"
 #include "base/time/time.h"
 #include "base/timer/timer.h"
 #include "media/audio/audio_io.h"
 #include "media/audio/audio_manager.h"
 #include "media/audio/audio_output_dispatcher_impl.h"
 #include "media/base/audio_parameters.h"
 
 namespace media {
 
@@ skipping 20 matching lines @@
 
   // AudioOutputDispatcher interface.
   AudioOutputProxy* CreateStreamProxy() override;
   bool OpenStream() override;
   bool StartStream(AudioOutputStream::AudioSourceCallback* callback,
                    AudioOutputProxy* stream_proxy) override;
   void StopStream(AudioOutputProxy* stream_proxy) override;
   void StreamVolumeSet(AudioOutputProxy* stream_proxy, double volume) override;
   void CloseStream(AudioOutputProxy* stream_proxy) override;
 
+  // Controls debug recording.

[DaleCurtis, 2017/01/24 01:12:02]

It seems like this should just be something like SetDebugRecordingCallback() and
then the caller to that maintains the complexity for setting up the debug
recorders in the right way. It's a bit odd to have AOR/OMDC setting up and
managing file names, etc. 

I realize it's a many-to-one relationship though, so perhaps the callback can
take an opaque stream id as well.

+  void EnableDebugRecording(const base::FilePath& file_name);
+  void DisableDebugRecording();
+
  private:
   using CallbackMap =
       std::map<AudioOutputProxy*, std::unique_ptr<OnMoreDataConverter>>;
 
   // Converts low latency based output parameters into high latency
   // appropriate output parameters in error situations.
   void SetupFallbackParams();
 
   // Used to reinitialize |dispatcher_|.
   void Reinitialize();
 
   // Used to initialize |dispatcher_|.
   void Initialize();
 
   // Stops the stream corresponding to the |item| in |callbacks_|.
   void StopStreamInternal(const CallbackMap::value_type& item);
 
+  // Helper function that conditionally starts debug recording.
+  void MaybeStartDebugRecording();
+
+  // The AudioManager that creates us.
+  AudioManager* audio_manager_;
+
   // Dispatcher to proxy all AudioOutputDispatcher calls too.
   std::unique_ptr<AudioOutputDispatcherImpl> dispatcher_;
 
   // Map of outstanding OnMoreDataConverter objects.  A new object is created
   // on every StartStream() call and destroyed on CloseStream().
   CallbackMap callbacks_;
 
   // Used by AudioOutputDispatcherImpl; kept so we can reinitialize on the fly.
   base::TimeDelta close_delay_;
 
   // AudioParameters used to setup the output stream; changed upon fallback.
   AudioParameters output_params_;
 
   // The original AudioParameters we were constructed with.
   const AudioParameters original_output_params_;
 
   // Whether any streams have been opened through |dispatcher_|, if so we can't
   // fallback on future OpenStream() failures.
   bool streams_opened_;
 
   // The reinitialization timer provides a way to recover from temporary failure
   // states by clearing the dispatcher if all proxies have been closed and none
   // have been created within |close_delay_|.  Without this, audio may be lost
   // to a fake stream indefinitely for transient errors.
   base::Timer reinitialize_timer_;
 
+  // Used for audio debug recordings. The file name is stored when enabling to
+  // be able to enable on new OnMoreDataConverters.
+  base::FilePath debug_recording_file_name_;
+
   base::WeakPtrFactory<AudioOutputResampler> weak_factory_;
   DISALLOW_COPY_AND_ASSIGN(AudioOutputResampler);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_AUDIO_AUDIO_OUTPUT_RESAMPLER_H_