Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2582553002: Refactor GL bindings so there is no global GLApi or DriverGL. (Closed)

Created:
4 years ago by Geoff Lang
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, piman+watch_chromium.org, ozone-reviews_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor GL bindings so there is no global GLApi or DriverGL. Having a single global API and Driver object doesn't mirror the real GL context state that may have different entry points, extensions and version numbers per context. This can cause entry points to be called when they are not loaded or extensions used when they are not present. * Refactored the GLApi and DriverGL objects to be owned by GLContext objects. * Moved all driver-level GL workarounds into RealGLApi so no swapping of function pointers in DriverGL is needed. * Instead of having separate debug function pointers in the drivers that call back to global variables, add new DebugApi objects that wrap the RealApi objects. BUG=671217 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Patch Set 2 : split bindings autogen file #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : . #

Patch Set 14 : . #

Patch Set 15 : . #

Patch Set 16 : . #

Patch Set 17 : . #

Patch Set 18 : . #

Patch Set 19 : . #

Patch Set 20 : . #

Patch Set 21 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18346 lines, -3513 lines) Patch
M gpu/command_buffer/service/context_group.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +5 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gl_context_mock.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gl_context_virtual.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gl_context_virtual.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +8 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 4 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gpu_service_test.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gpu_service_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/mailbox_manager_sync.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/memory_program_cache.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +15 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/texture_definition.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +2 lines, -1 line 0 comments Download
M gpu/command_buffer/tests/fuzzer_main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +7 lines, -10 lines 0 comments Download
M gpu/config/gpu_info_collector_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +12 lines, -0 lines 0 comments Download
M gpu/ipc/in_process_command_buffer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/ipc/service/gpu_channel_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/ipc/service/gpu_channel_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +1 line, -5 lines 0 comments Download
M gpu/ipc/service/gpu_command_buffer_stub.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +8 lines, -5 lines 0 comments Download
M gpu/ipc/service/image_transport_surface_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +2 lines, -1 line 0 comments Download
M gpu/ipc/service/image_transport_surface_mac.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/service/image_transport_surface_overlay_mac.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -2 lines 0 comments Download
M gpu/ipc/service/image_transport_surface_overlay_mac.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 4 chunks +0 lines, -4 lines 0 comments Download
M ui/gl/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +5 lines, -5 lines 0 comments Download
M ui/gl/generate_bindings.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 6 chunks +64 lines, -91 lines 0 comments Download
M ui/gl/gl_api_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 6 chunks +17 lines, -38 lines 0 comments Download
M ui/gl/gl_bindings.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 5 chunks +13 lines, -22 lines 0 comments Download
M ui/gl/gl_bindings_autogen_egl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +948 lines, -1314 lines 0 comments Download
A ui/gl/gl_bindings_autogen_gl0.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +2453 lines, -0 lines 0 comments Download
A ui/gl/gl_bindings_autogen_gl1.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +2587 lines, -0 lines 0 comments Download
A ui/gl/gl_bindings_autogen_gl2.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +4020 lines, -0 lines 0 comments Download
A ui/gl/gl_bindings_autogen_gl3.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +3040 lines, -0 lines 0 comments Download
A ui/gl/gl_bindings_autogen_gl4.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +3428 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_autogen_glx.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +706 lines, -1000 lines 0 comments Download
M ui/gl/gl_bindings_autogen_osmesa.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +114 lines, -183 lines 0 comments Download
M ui/gl/gl_bindings_autogen_wgl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +180 lines, -304 lines 0 comments Download
M ui/gl/gl_context.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 4 chunks +28 lines, -1 line 0 comments Download
M ui/gl/gl_context.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 9 chunks +74 lines, -15 lines 0 comments Download
M ui/gl/gl_context_cgl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +14 lines, -1 line 0 comments Download
M ui/gl/gl_context_egl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_glx.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_osmesa.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_stub.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +13 lines, -0 lines 0 comments Download
M ui/gl/gl_context_stub.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +47 lines, -3 lines 0 comments Download
D ui/gl/gl_context_stub_with_extensions.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +0 lines, -40 lines 0 comments Download
D ui/gl/gl_context_stub_with_extensions.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +0 lines, -36 lines 0 comments Download
M ui/gl/gl_context_wgl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_egl_api_implementation.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +14 lines, -0 lines 0 comments Download
M ui/gl/gl_egl_api_implementation.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +14 lines, -20 lines 0 comments Download
M ui/gl/gl_fence.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +11 lines, -10 lines 0 comments Download
M ui/gl/gl_fence_arb.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +4 lines, -2 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 5 chunks +80 lines, -14 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 10 chunks +173 lines, -266 lines 0 comments Download
M ui/gl/gl_glx_api_implementation.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +15 lines, -0 lines 0 comments Download
M ui/gl/gl_glx_api_implementation.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +12 lines, -1 line 0 comments Download
M ui/gl/gl_image_io_surface.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +0 lines, -3 lines 0 comments Download
M ui/gl/gl_image_memory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_implementation.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 4 chunks +10 lines, -1 line 0 comments Download
M ui/gl/gl_implementation.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 5 chunks +33 lines, -15 lines 0 comments Download
M ui/gl/gl_osmesa_api_implementation.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +15 lines, -0 lines 0 comments Download
M ui/gl/gl_osmesa_api_implementation.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +14 lines, -2 lines 0 comments Download
M ui/gl/gl_stub_api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -2 lines 0 comments Download
M ui/gl/gl_switches.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_switches.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_wgl_api_implementation.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +15 lines, -0 lines 0 comments Download
M ui/gl/gl_wgl_api_implementation.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +14 lines, -2 lines 0 comments Download
M ui/gl/gpu_timing_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +4 lines, -4 lines 0 comments Download
M ui/gl/init/gl_factory_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +8 lines, -1 line 0 comments Download
M ui/gl/init/gl_factory_mac.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +8 lines, -0 lines 0 comments Download
M ui/gl/init/gl_factory_ozone.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 4 chunks +10 lines, -1 line 0 comments Download
M ui/gl/init/gl_factory_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +8 lines, -0 lines 0 comments Download
M ui/gl/init/gl_factory_x11.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +8 lines, -0 lines 0 comments Download
M ui/gl/init/gl_initializer_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +2 lines, -1 line 0 comments Download
M ui/gl/init/gl_initializer_mac.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +2 lines, -1 line 0 comments Download
M ui/gl/init/gl_initializer_ozone.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +3 lines, -1 line 0 comments Download
M ui/gl/init/gl_initializer_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +3 lines, -1 line 0 comments Download
M ui/gl/init/gl_initializer_x11.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +2 lines, -1 line 0 comments Download
D ui/gl/scoped_api.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +0 lines, -28 lines 0 comments Download
D ui/gl/scoped_api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +0 lines, -20 lines 0 comments Download
M ui/gl/test/gl_surface_test_support.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/test/gl_surface_test_support.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +8 lines, -0 lines 0 comments Download
M ui/gl/yuv_to_rgb_converter.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 4 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 79 (79 generated)
Geoff Lang
Description was changed from ========== Refactor GL bindings so there is no global GLApi or ...
4 years ago (2016-12-15 15:37:31 UTC) #1
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
4 years ago (2016-12-15 16:02:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/10001
4 years ago (2016-12-15 16:02:57 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-15 16:15:02 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/278786)
4 years ago (2016-12-15 16:15:03 UTC) #5
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
4 years ago (2016-12-15 21:19:21 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/20001
4 years ago (2016-12-15 21:20:44 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-15 21:33:50 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/355464)
4 years ago (2016-12-15 21:33:51 UTC) #9
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
4 years ago (2016-12-15 23:07:20 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/10002
4 years ago (2016-12-15 23:09:32 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-15 23:25:58 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/324727) mac_optional_gpu_tests_rel on ...
4 years ago (2016-12-15 23:25:59 UTC) #13
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
4 years ago (2016-12-16 19:00:47 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/30001
4 years ago (2016-12-16 19:01:16 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-16 19:28:31 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/182774)
4 years ago (2016-12-16 19:28:32 UTC) #17
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
4 years ago (2016-12-16 20:59:25 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/40001
4 years ago (2016-12-16 21:01:11 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-16 21:28:46 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/182888) chromeos_amd64-generic_chromium_compile_only_ng on ...
4 years ago (2016-12-16 21:28:47 UTC) #21
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
4 years ago (2016-12-19 21:58:15 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/50001
4 years ago (2016-12-19 21:58:51 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-19 22:34:24 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/359419) mac_chromium_compile_dbg_ng on ...
4 years ago (2016-12-19 22:34:25 UTC) #25
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
4 years ago (2016-12-20 21:43:29 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/60001
4 years ago (2016-12-20 21:44:26 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-20 22:03:10 UTC) #28
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/5885)
4 years ago (2016-12-20 22:03:11 UTC) #29
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
4 years ago (2016-12-21 21:00:13 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/70001
4 years ago (2016-12-21 21:00:51 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-21 21:16:32 UTC) #32
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/327915)
4 years ago (2016-12-21 21:16:33 UTC) #33
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
4 years ago (2016-12-21 22:28:38 UTC) #34
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/80001
4 years ago (2016-12-21 22:29:23 UTC) #35
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-21 22:48:41 UTC) #36
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/327983)
4 years ago (2016-12-21 22:48:43 UTC) #37
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
4 years ago (2016-12-22 16:51:46 UTC) #38
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/90001
4 years ago (2016-12-22 16:52:02 UTC) #39
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-22 17:08:46 UTC) #40
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/337857)
4 years ago (2016-12-22 17:08:48 UTC) #41
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
4 years ago (2016-12-22 18:18:59 UTC) #42
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/100001
4 years ago (2016-12-22 18:19:18 UTC) #43
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
4 years ago (2016-12-22 18:47:59 UTC) #44
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/110001
4 years ago (2016-12-22 18:48:21 UTC) #45
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-22 19:14:02 UTC) #46
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/5948)
4 years ago (2016-12-22 19:14:03 UTC) #47
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
4 years ago (2016-12-22 20:11:14 UTC) #48
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/120001
4 years ago (2016-12-22 20:11:53 UTC) #49
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-22 21:44:13 UTC) #50
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/361766)
4 years ago (2016-12-22 21:44:14 UTC) #51
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-10 21:43:18 UTC) #52
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/130001
3 years, 11 months ago (2017-01-10 21:43:58 UTC) #53
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-10 22:33:25 UTC) #54
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/366060)
3 years, 11 months ago (2017-01-10 22:33:26 UTC) #55
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-11 16:13:46 UTC) #56
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/140001
3 years, 11 months ago (2017-01-11 16:14:07 UTC) #57
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-11 17:14:53 UTC) #58
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/366774)
3 years, 11 months ago (2017-01-11 17:14:55 UTC) #59
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-11 17:53:21 UTC) #60
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/150001
3 years, 11 months ago (2017-01-11 17:53:45 UTC) #61
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-11 19:49:36 UTC) #62
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/366867)
3 years, 11 months ago (2017-01-11 19:49:37 UTC) #63
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-11 20:53:04 UTC) #64
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/160001
3 years, 11 months ago (2017-01-11 20:53:37 UTC) #65
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-11 21:12:28 UTC) #66
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/367020)
3 years, 11 months ago (2017-01-11 21:12:30 UTC) #67
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-11 22:02:22 UTC) #68
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/170001
3 years, 11 months ago (2017-01-11 22:04:06 UTC) #69
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-11 22:20:03 UTC) #70
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/335748)
3 years, 11 months ago (2017-01-11 22:20:04 UTC) #71
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-12 14:48:23 UTC) #72
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/180001
3 years, 11 months ago (2017-01-12 14:48:44 UTC) #73
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-12 15:54:46 UTC) #74
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/367689)
3 years, 11 months ago (2017-01-12 15:54:48 UTC) #75
Geoff Lang
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-12 19:25:33 UTC) #76
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582553002/190001
3 years, 11 months ago (2017-01-12 19:26:11 UTC) #77
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-12 20:38:57 UTC) #78
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 20:38:58 UTC) #79
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698