Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2582543003: Update GC stats, ThreadPool, Timer and ScopedTimer to use monotonic time. (Closed)

Created:
4 years ago by rmacnak
Modified:
4 years ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update GC stats, ThreadPool, Timer and ScopedTimer to use monotonic time. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/8c6dca095c6ecb6c286eef63b3e6527289b0f510

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -30 lines) Patch
M runtime/vm/heap.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/pages.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/scavenger.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/scope_timer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/thread_pool.cc View 1 2 3 2 chunks +8 lines, -6 lines 0 comments Download
M runtime/vm/thread_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/timer.h View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rmacnak
4 years ago (2016-12-15 22:57:35 UTC) #3
Cutch
LGTM w/c https://codereview.chromium.org/2582543003/diff/40001/runtime/vm/thread_pool.cc File runtime/vm/thread_pool.cc (right): https://codereview.chromium.org/2582543003/diff/40001/runtime/vm/thread_pool.cc#newcode15 runtime/vm/thread_pool.cc:15: 5000000, consider keeping the command line flag ...
4 years ago (2016-12-15 22:59:24 UTC) #4
rmacnak
https://codereview.chromium.org/2582543003/diff/40001/runtime/vm/thread_pool.cc File runtime/vm/thread_pool.cc (right): https://codereview.chromium.org/2582543003/diff/40001/runtime/vm/thread_pool.cc#newcode15 runtime/vm/thread_pool.cc:15: 5000000, On 2016/12/15 22:59:24, Cutch wrote: > consider keeping ...
4 years ago (2016-12-15 23:11:27 UTC) #5
rmacnak
4 years ago (2016-12-15 23:25:11 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
8c6dca095c6ecb6c286eef63b3e6527289b0f510 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698