media: Verify CDM Host files

content/browser/ppapi_plugin_process_host.cc

Index: content/browser/ppapi_plugin_process_host.cc
diff --git a/content/browser/ppapi_plugin_process_host.cc b/content/browser/ppapi_plugin_process_host.cc
index 7b541e7b6528313fca6fca9e57c999326d691653..8c58dd92a01edb314fa40b3ba2c312478c949ba1 100644
--- a/content/browser/ppapi_plugin_process_host.cc
+++ b/content/browser/ppapi_plugin_process_host.cc
@@ -33,6 +33,7 @@
 #include "content/public/common/sandbox_type.h"
 #include "content/public/common/sandboxed_process_launcher_delegate.h"
 #include "content/public/common/service_names.mojom.h"
+#include "media/base/media_switches.h"
 #include "mojo/edk/embedder/embedder.h"
 #include "net/base/network_change_notifier.h"
 #include "ppapi/proxy/ppapi_messages.h"
@@ -399,6 +400,8 @@ bool PpapiPluginProcessHost::Init(const PepperPluginInfo& info) {
 #if defined(OS_MACOSX)
       switches::kEnableSandboxLogging,
 #endif
+      // Need to tell CdmHostFile(s) to ignore missing CDM host files in tests.
+      switches::kIgnoreMissingCdmHostFileForTesting,

[jam, 2017/01/23 17:45:44]

this isn't a testing only flag anymore then?

[xhwang, 2017/01/23 23:16:09]

Agreed. Though the purpose of adding such a flag is for testing, it can be
enabled by non-testing code.

I updated the switch name by dropping the "ForTesting" part.

[jam, 2017/01/24 00:39:24]

Can you help me understand this more? I see you removed the ForTesting in the
name, but the comment is there. If this is only for tests, why is this file
passing this flag instead of only the test harness (content_browsertests?). Do
we really want production code to ignore this in pepper processes?

[xhwang, 2017/01/24 01:14:19]

err, my bad. I should drop the "in tests" part from this comment. The flag will
also work in production.

This flag will be used in two cases:
- In the browser_tests added as part of this CL (not in content_browsertests).
- By developers to test the functionality even when some host files are missing
(e.g. when running a Chromium build).

       switches::kNoSandbox,
       switches::kPpapiStartupDialog,
     };