media: Verify CDM Host files

chrome/common/media/cdm_host_file_path.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/common/media/cdm_host_file_path.h"
+
+#include "base/files/file_path.h"
+#include "base/files/file_util.h"
+#include "base/logging.h"
+#include "base/macros.h"
+#include "base/memory/ptr_util.h"
+#include "base/path_service.h"
+#include "build/build_config.h"
+#include "chrome/common/chrome_version.h"
+
+#if defined(OS_MACOSX)
+#include "base/mac/bundle_locations.h"
+#include "chrome/common/chrome_constants.h"
+#endif
+
+namespace chrome {
+
+namespace {
+
+using content::CdmHostFilePath;
+
+// TODO(xhwang): Move this to a common place if needed.
+const base::FilePath::CharType kSignatureFileExtension[] =
+    FILE_PATH_LITERAL(".sig");
+
+// Returns the signature file path given the |file_path|. This function should
+// only be used when the signature file and the file are located in the same
+// directory.
+base::FilePath GetSigFilePath(const base::FilePath& file_path) {
+  return file_path.AddExtension(kSignatureFileExtension);
+}
+
+#if defined(OS_WIN)
+
+void AddCdmHostFilePathsWin(std::vector<CdmHostFilePath>* cdm_host_file_paths) {
+  static const base::FilePath::CharType* const kUnversionedFiles[] = {
+      FILE_PATH_LITERAL("chrome.exe")};
+  static const base::FilePath::CharType* const kVersionedFiles[] = {
+      FILE_PATH_LITERAL("chrome.dll"), FILE_PATH_LITERAL("chrome_child.dll")};
+
+  // Find where chrome.exe is installed.
+  base::FilePath chrome_exe_dir;
+  if (!PathService::Get(base::DIR_EXE, &chrome_exe_dir))
+    NOTREACHED();
+
+  cdm_host_file_paths->reserve(arraysize(kUnversionedFiles) +
+                               arraysize(kVersionedFiles));
+
+  for (size_t i = 0; i < arraysize(kUnversionedFiles); ++i) {
+    base::FilePath file_path = chrome_exe_dir.Append(kUnversionedFiles[i]);
+    DVLOG(2) << __func__ << ": unversioned file " << i << " at "
+             << file_path.value();
+    cdm_host_file_paths->push_back(
+        CdmHostFilePath(file_path, GetSigFilePath(file_path)));
+  }
+
+  base::FilePath version_dir(chrome_exe_dir.AppendASCII(CHROME_VERSION_STRING));
+  for (size_t i = 0; i < arraysize(kVersionedFiles); ++i) {
+    base::FilePath file_path = version_dir.Append(kVersionedFiles[i]);
+    DVLOG(2) << __func__ << ": versioned file " << i << " at "
+             << file_path.value();
+    cdm_host_file_paths->push_back(
+        CdmHostFilePath(file_path, GetSigFilePath(file_path)));
+  }
+}
+
+#elif defined(OS_MACOSX)
+
+void AddCdmHostFilePathsMac(std::vector<CdmHostFilePath>* cdm_host_file_paths) {
+  base::FilePath chrome_framework_path =
+      base::mac::FrameworkBundlePath().Append(chrome::kFrameworkExecutableName);
+
+  DVLOG(2) << __func__
+           << ": chrome_framework_path=" << chrome_framework_path.value();
+  cdm_host_file_paths->push_back(CdmHostFilePath(
+      chrome_framework_path, GetSigFilePath(chrome_framework_path)));
+}
+
+#elif defined(OS_LINUX)
+
+void AddCdmHostFilePathsLinux(
+    std::vector<CdmHostFilePath>* cdm_host_file_paths) {
+  base::FilePath chrome_exe_dir;
+  if (!PathService::Get(base::DIR_EXE, &chrome_exe_dir))
+    NOTREACHED();
+
+  base::FilePath chrome_path =
+      chrome_exe_dir.Append(FILE_PATH_LITERAL("chrome"));
+  DVLOG(2) << __func__ << ": chrome_path=" << chrome_path.value();
+  cdm_host_file_paths->push_back(
+      CdmHostFilePath(chrome_path, GetSigFilePath(chrome_path)));
+}
+
+#endif  // defined(OS_WIN)
+
+}  // namespace
+
+void AddCdmHostFilePaths(
+    std::vector<content::CdmHostFilePath>* cdm_host_file_paths) {
+  DVLOG(1) << __func__;
+  DCHECK(cdm_host_file_paths);
+  DCHECK(cdm_host_file_paths->empty());
+
+#if defined(OS_WIN)
+  AddCdmHostFilePathsWin(cdm_host_file_paths);

[jam, 2017/01/24 00:39:24]

nit: name the method the same on all platforms and then you can just have one
call here. you can even just have one method definition and move the ifdef
inside of it.

[xhwang, 2017/01/24 01:14:19]

Done.

+#elif defined(OS_MACOSX)
+  AddCdmHostFilePathsMac(cdm_host_file_paths);
+#elif defined(OS_LINUX)
+  AddCdmHostFilePathsLinux(cdm_host_file_paths);
+#endif  // defined(OS_WIN)
+}
+
+}  // namespace chrome