Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2582463002: Fix webkitGetEntry for non-native files. (Closed)

Created:
4 years ago by hirono
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Fix webkitGetEntry for non-native files. Previously webkitGetEntry was broken for non-native files. The method creates FileEntry in isolated file system from DataTransferItem. The problem is DataTransferItem only has file system ID of isolated file system containing native files, though the browser process prepares different isolated file system for non-native files. The CL adds new field 'fileSystemId' for types representing a non-native file and let webkitGetEntry refer the fileSystemId so that it can return valid FileEntry for non-native files. BUG=671811 TEST=Drop a file from Chrome OS Files app to Google Drive web. Review-Url: https://codereview.chromium.org/2565283002 Cr-Commit-Position: refs/heads/master@{#438455} (cherry picked from commit da08349d4b87496c619152256ab039f6f6d2f28b) Committed: https://chromium.googlesource.com/chromium/src/+/0fff0c9efd40d9bbe9bc99fa239a89a4f241fedb

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -48 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 3 chunks +6 lines, -1 line 0 comments Download
M content/common/drag_traits.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/drop_data.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/drop_data_builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataObject.h View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataObject.cpp View 6 chunks +31 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataObjectItem.h View 3 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataObjectItem.cpp View 2 chunks +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataObjectTest.cpp View 3 chunks +33 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DraggedIsolatedFileSystem.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DraggedIsolatedFileSystem.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DraggedIsolatedFileSystemImpl.h View 2 chunks +7 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DraggedIsolatedFileSystemImpl.cpp View 2 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/public/platform/WebDragData.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582463002/1
4 years ago (2016-12-15 06:53:40 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-15 06:53:42 UTC) #4
hirono
4 years ago (2016-12-15 07:51:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0fff0c9efd40d9bbe9bc99fa239a89a4f241fedb.

Powered by Google App Engine
This is Rietveld 408576698