Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: base/trace_event/memory_dump_session_state.cc

Issue 2582453002: [tracing] Implement polling in MemoryDumpManager (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/memory_dump_session_state.cc
diff --git a/base/trace_event/memory_dump_session_state.cc b/base/trace_event/memory_dump_session_state.cc
index 3e3bedbb2989b382dab7c85cc002dbc4f4287b64..dbafbe0c8fce39ef30ca59ec0568faddf60b77f0 100644
--- a/base/trace_event/memory_dump_session_state.cc
+++ b/base/trace_event/memory_dump_session_state.cc
@@ -7,8 +7,7 @@
namespace base {
namespace trace_event {
-MemoryDumpSessionState::MemoryDumpSessionState() : is_polling_enabled_(false) {}
-
+MemoryDumpSessionState::MemoryDumpSessionState() {}
MemoryDumpSessionState::~MemoryDumpSessionState() {}
void MemoryDumpSessionState::SetStackFrameDeduplicator(
@@ -23,13 +22,14 @@ void MemoryDumpSessionState::SetTypeNameDeduplicator(
type_name_deduplicator_ = std::move(type_name_deduplicator);
}
-void MemoryDumpSessionState::SetMemoryDumpConfig(
- const TraceConfig::MemoryDumpConfig& config) {
- memory_dump_config_ = config;
- for (const auto& trigger : config.triggers) {
- if (trigger.trigger_type == MemoryDumpType::PEAK_MEMORY_USAGE)
- is_polling_enabled_ = true;
- }
+void MemoryDumpSessionState::SetAllowedDumpModes(
+ std::set<MemoryDumpLevelOfDetail> allowed_dump_modes) {
+ allowed_dump_modes_ = allowed_dump_modes;
+}
+
+bool MemoryDumpSessionState::IsDumpModeAllowed(
+ MemoryDumpLevelOfDetail dump_mode) const {
+ return allowed_dump_modes_.count(dump_mode) != 0;
}
} // namespace trace_event

Powered by Google App Engine
This is Rietveld 408576698