third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp - Issue 2582443004: ScriptProcessor buffer size should be consistent with callback size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

Issue 2582443004: ScriptProcessor buffer size should be consistent with callback size (Closed)

Patch Set: Make callbackBufferSize pure virtual Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h ('k') | third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp b/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

index 2b343435014e5c1de43aa2b03ef702b6bdf91b37..c39d0d2af0c37f00d4d42a275f7a8d5f7e47103d 100644

--- a/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

@@ -133,6 +133,11 @@ void OfflineAudioDestinationHandler::stopRendering() {

ASSERT_NOT_REACHED();

}

+size_t OfflineAudioDestinationHandler::callbackBufferSize() const {

+ // The callback buffer size has no meaning for an offline context.

+ NOTREACHED();

+ return 0;

WebThread* OfflineAudioDestinationHandler::offlineRenderThread() {

DCHECK(m_renderThread);