Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioNode.h

Issue 2582443004: ScriptProcessor buffer size should be consistent with callback size (Closed)
Patch Set: Make callbackBufferSize pure virtual Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioNode.h
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioNode.h b/third_party/WebKit/Source/modules/webaudio/AudioNode.h
index 71adc2dc9b586fa158271080e7aa5482efd2d00f..37df1767259ba87033dab7b0ea1c03129698fde5 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioNode.h
+++ b/third_party/WebKit/Source/modules/webaudio/AudioNode.h
@@ -229,6 +229,11 @@ class MODULES_EXPORT AudioHandler : public ThreadSafeRefCounted<AudioHandler> {
void updateChannelCountMode();
void updateChannelInterpretation();
+ // Default callbackBufferSize should be the render quantum size
+ virtual size_t callbackBufferSize() const {
+ return AudioUtilities::kRenderQuantumFrames;
+ }
+
protected:
// Inputs and outputs must be created before the AudioHandler is
// initialized.

Powered by Google App Engine
This is Rietveld 408576698