ScriptProcessor buffer size should be consistent with callback size

third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h

Index: third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h b/third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h
index dc7fe45b785aa4c552a80638aed3a35d425c3ec1..8503cbe966cfe64e549770861f55a165d5534de6 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h
+++ b/third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h
@@ -65,6 +65,8 @@ class AudioDestinationHandler : public AudioHandler, public AudioIOCallback {
   virtual void startRendering() = 0;
   virtual void stopRendering() = 0;
 
+  virtual size_t callbackBufferSize() const { return 0; }

[hongchan, 2016/12/20 20:35:13]

The comment is needed here. We have many 'callbacks' and 'buffers' in the code,
so it is good to specify what it is for.

[Raymond Toy, 2016/12/20 21:55:31]

Done.

And also made it pure virtual as we discussed.

+
  protected:
   // LocalAudioInputProvider allows us to expose an AudioSourceProvider for
   // local/live audio input.  If there is local/live audio input, we call set()
@@ -111,6 +113,7 @@ class AudioDestinationNode : public AudioNode {
   AudioDestinationHandler& audioDestinationHandler() const;
 
   unsigned long maxChannelCount() const;
+  size_t callbackBufferSize() const { return handler().callbackBufferSize(); }

[hongchan, 2016/12/20 20:35:12]

Just curious: does this change dynamically? if not, can we just populate it at
the instantiation?

[Raymond Toy, 2016/12/20 21:55:31]

Don't think this can change dynamically.  Might be able to populate it at
instantiation, but the derived classes are the only ones who know what the value
should be, so they need to be queried anyway.

 
  protected:
   AudioDestinationNode(BaseAudioContext&);