Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: src/accessors.h

Issue 258243003: Remove old-style accessor support from runtime. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address comment Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/accessors.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/accessors.h
diff --git a/src/accessors.h b/src/accessors.h
index 866847a0d999dfe253b3c1a2c9dbda68acf55003..ed0a18bf61cd8609da5358443f3d9bb602f2feac 100644
--- a/src/accessors.h
+++ b/src/accessors.h
@@ -36,9 +36,6 @@ namespace internal {
// The list of accessor descriptors. This is a second-order macro
// taking a macro to be applied to all accessor descriptor names.
-#define ACCESSOR_DESCRIPTOR_LIST(V) \
-
-
#define ACCESSOR_INFO_LIST(V) \
V(ArrayLength) \
V(FunctionArguments) \
@@ -65,11 +62,6 @@ namespace internal {
class Accessors : public AllStatic {
public:
// Accessor descriptors.
-#define ACCESSOR_DESCRIPTOR_DECLARATION(name) \
- static const AccessorDescriptor name;
- ACCESSOR_DESCRIPTOR_LIST(ACCESSOR_DESCRIPTOR_DECLARATION)
-#undef ACCESSOR_DESCRIPTOR_DECLARATION
-
#define ACCESSOR_INFO_DECLARATION(name) \
static void name##Getter( \
v8::Local<v8::String> name, \
@@ -85,10 +77,6 @@ class Accessors : public AllStatic {
#undef ACCESSOR_INFO_DECLARATION
enum DescriptorId {
-#define ACCESSOR_DESCRIPTOR_DECLARATION(name) \
- k##name,
- ACCESSOR_DESCRIPTOR_LIST(ACCESSOR_DESCRIPTOR_DECLARATION)
-#undef ACCESSOR_DESCRIPTOR_DECLARATION
#define ACCESSOR_INFO_DECLARATION(name) \
k##name##Getter, \
k##name##Setter,
@@ -114,27 +102,16 @@ class Accessors : public AllStatic {
Handle<String> name,
int* object_offset);
- private:
- static Object* FunctionGetCaller(Isolate* isolate,
- Object* object,
- void*);
- static Object* ArraySetLength(Isolate* isolate,
- JSObject* object,
- Object*,
- void*);
- static Object* ArrayGetLength(Isolate* isolate, Object* object, void*);
+ static Handle<AccessorInfo> MakeAccessor(
+ Isolate* isolate,
+ Handle<String> name,
+ AccessorGetterCallback getter,
+ AccessorSetterCallback setter,
+ PropertyAttributes attributes);
+ private:
// Helper functions.
static Handle<Object> FlattenNumber(Isolate* isolate, Handle<Object> value);
- static Object* IllegalSetter(Isolate* isolate,
- JSObject*,
- Object*,
- void*);
- static Object* IllegalGetAccessor(Isolate* isolate, Object* object, void*);
- static Object* ReadOnlySetAccessor(Isolate* isolate,
- JSObject*,
- Object* value,
- void*);
};
} } // namespace v8::internal
« no previous file with comments | « no previous file | src/accessors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698