Support "Pin to taskbar" for hosted app windows.

Support "Pin to taskbar" for hosted app windows.

This CL allows hosted app windows to be pinned to the taskbar by
right-clicking the taskbar icon and pressing the "Pin to taskbar" button.

This CL pulls out the code that sets the relaunch details of v2 app
windows into web::UpdateRelaunchDetails.

BUG=368101
TEST=Run a hosted app as a window. Pin it from the taskbar icon right click
menu. Relaunch the app from the pinned icon.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272851

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272923

[jackhou1, 2014-04-29 08:50:18]

https://codereview.chromium.org/258243002/diff/30009/chrome/browser/web_appli...
File chrome/browser/web_applications/update_relaunch_details_worker_win.cc
(right):

https://codereview.chromium.org/258243002/diff/30009/chrome/browser/web_appli...
chrome/browser/web_applications/update_relaunch_details_worker_win.cc:34:
extension_,
Do you really need a worker object for this code? It looks like it only carries
extension_ and profile_ as far as Run(). hwnd_ is used in
CreateIconAndSetRelaunchDetails, but from another thread, so it's not
technically safe. You could probably get away with just a bunch of functions
that do the same thing. You could still have them in this separate file though
(but rename to remove "worker").

https://codereview.chromium.org/258243002/diff/30009/chrome/browser/web_appli...
File chrome/browser/web_applications/update_relaunch_details_worker_win.h
(right):

https://codereview.chromium.org/258243002/diff/30009/chrome/browser/web_appli...
chrome/browser/web_applications/update_relaunch_details_worker_win.h:8: #include
"chrome/browser/shell_integration.h"
You probably need to sync. It's web_app::ShortcutInfo now, so you won't need
this include.

https://codereview.chromium.org/258243002/diff/30009/chrome/browser/web_appli...
File chrome/browser/web_applications/web_app_win.cc (right):

https://codereview.chromium.org/258243002/diff/30009/chrome/browser/web_appli...
chrome/browser/web_applications/web_app_win.cc:361: UpdateRelaunchDetailsWorker*
worker =
You can
new UpdateRelaunchDetailsWorker(profile, extension, hwnd)->Run();

[calamity, 2014-05-19 06:11:53]

Ack, didn't upload a rebase patch. I think it's not going to matter too much
here since all the relevant diff changes are in web_app_win.cc which pretty much
changed completely anyway. Sorry about that.

https://codereview.chromium.org/258243002/diff/30009/chrome/browser/web_appli...
File chrome/browser/web_applications/update_relaunch_details_worker_win.cc
(right):

https://codereview.chromium.org/258243002/diff/30009/chrome/browser/web_appli...
chrome/browser/web_applications/update_relaunch_details_worker_win.cc:34:
extension_,
On 2014/04/29 08:50:18, jackhou1 wrote:
> Do you really need a worker object for this code? It looks like it only
carries
> extension_ and profile_ as far as Run(). hwnd_ is used in
> CreateIconAndSetRelaunchDetails, but from another thread, so it's not
> technically safe. You could probably get away with just a bunch of functions
> that do the same thing. You could still have them in this separate file though
> (but rename to remove "worker").

Good point. HWND doesn't need to be safe????

https://codereview.chromium.org/258243002/diff/30009/chrome/browser/web_appli...
File chrome/browser/web_applications/update_relaunch_details_worker_win.h
(right):

https://codereview.chromium.org/258243002/diff/30009/chrome/browser/web_appli...
chrome/browser/web_applications/update_relaunch_details_worker_win.h:8: #include
"chrome/browser/shell_integration.h"
On 2014/04/29 08:50:18, jackhou1 wrote:
> You probably need to sync. It's web_app::ShortcutInfo now, so you won't need
> this include.

Done.

https://codereview.chromium.org/258243002/diff/30009/chrome/browser/web_appli...
File chrome/browser/web_applications/web_app_win.cc (right):

https://codereview.chromium.org/258243002/diff/30009/chrome/browser/web_appli...
chrome/browser/web_applications/web_app_win.cc:361: UpdateRelaunchDetailsWorker*
worker =
On 2014/04/29 08:50:18, jackhou1 wrote:
> You can
> new UpdateRelaunchDetailsWorker(profile, extension, hwnd)->Run();

No longer applicable.

[jackhou1, 2014-05-22 03:43:53]

lgtm

CL description needs update.

https://codereview.chromium.org/258243002/diff/30009/chrome/browser/web_appli...
File chrome/browser/web_applications/update_relaunch_details_worker_win.cc
(right):

https://codereview.chromium.org/258243002/diff/30009/chrome/browser/web_appli...
chrome/browser/web_applications/update_relaunch_details_worker_win.cc:34:
extension_,
On 2014/05/19 06:11:54, calamity wrote:
> On 2014/04/29 08:50:18, jackhou1 wrote:
> > Do you really need a worker object for this code? It looks like it only
> carries
> > extension_ and profile_ as far as Run(). hwnd_ is used in
> > CreateIconAndSetRelaunchDetails, but from another thread, so it's not
> > technically safe. You could probably get away with just a bunch of functions
> > that do the same thing. You could still have them in this separate file
though
> > (but rename to remove "worker").
> 
> Good point. HWND doesn't need to be safe????

I mean that accessing a member of UpdateRelaunchDetailsWorker from a thread that
does not own it is unsafe.

[calamity, 2014-05-23 03:58:38]

+sky for c/b/ui/views OWNERS.

Thanks.

[sky, 2014-05-23 13:27:26]

LGTM

https://codereview.chromium.org/258243002/diff/100001/chrome/browser/web_appl...
File chrome/browser/web_applications/web_app_win.cc (right):

https://codereview.chromium.org/258243002/diff/100001/chrome/browser/web_appl...
chrome/browser/web_applications/web_app_win.cc:347: if
(!base::PathExists(web_app_path) && !base::CreateDirectory(web_app_path)) {
nit: no {}

[calamity, 2014-05-26 01:54:47]

https://codereview.chromium.org/258243002/diff/100001/chrome/browser/web_appl...
File chrome/browser/web_applications/web_app_win.cc (right):

https://codereview.chromium.org/258243002/diff/100001/chrome/browser/web_appl...
chrome/browser/web_applications/web_app_win.cc:347: if
(!base::PathExists(web_app_path) && !base::CreateDirectory(web_app_path)) {
On 2014/05/23 13:27:27, sky wrote:
> nit: no {}

Done.

[calamity, 2014-05-26 01:55:42]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-05-26 01:56:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/calamity@chromium.org/258243002/140001

[commit-bot: I haz the power, 2014-05-26 16:34:46]

Change committed as 272851

[sergeyv, 2014-05-26 19:07:53]

A revert of this CL has been created in
https://codereview.chromium.org/298003005/ by sergeyv@chromium.org.

The reason for reverting is: Suspect to cause failure on Vista machines:
http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%283%29/bui....

[calamity, 2014-05-27 01:09:32]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-05-27 01:09:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/calamity@chromium.org/258243002/160001

[commit-bot: I haz the power, 2014-05-27 05:13:14]

Change committed as 272923