Merge WorldImpl with ResolutionWorldBuilderImpl

Merge WorldImpl with ResolutionWorldBuilderImpl

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/d0279d7c3e687095978e6c5bd7cde103a294ebb5

[Johnni Winther, 2016-12-19 15:21:31]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Johnni Winther, 2016-12-20 08:36:12]

ping

[Siggi Cherem (dart-lang), 2016-12-20 15:42:33]

lgtm! yay!

https://codereview.chromium.org/2582393002/diff/1/pkg/compiler/lib/src/enqueu...
File pkg/compiler/lib/src/enqueue.dart (right):

https://codereview.chromium.org/2582393002/diff/1/pkg/compiler/lib/src/enqueu...
pkg/compiler/lib/src/enqueue.dart:171: ResolutionWorldBuilder get universe =>
_universe;
let's add a TODO: rename `universe` to `worldBuilder` ?

When doing so, consider getting rid of the getter too (since the underlying
_universe is final, we could use the public name for the field instead)

[Johnni Winther, 2016-12-21 08:52:28]

https://codereview.chromium.org/2582393002/diff/1/pkg/compiler/lib/src/enqueu...
File pkg/compiler/lib/src/enqueue.dart (right):

https://codereview.chromium.org/2582393002/diff/1/pkg/compiler/lib/src/enqueu...
pkg/compiler/lib/src/enqueue.dart:171: ResolutionWorldBuilder get universe =>
_universe;
On 2016/12/20 15:42:33, Siggi Cherem (dart-lang) wrote:
> let's add a TODO: rename `universe` to `worldBuilder` ?
> 
> When doing so, consider getting rid of the getter too (since the underlying
> _universe is final, we could use the public name for the field instead)

Added a TODO to [Enqueuer.universe].

_universe has type ResolutionWorldBuilderImpl and I want to have two levels of
visibility. For now it is a misuse of implementation details but the
internal/external interfaces will be cleaned up.

[Johnni Winther, 2016-12-21 08:57:35]

Description was changed from

==========
Merge WorldImpl with ResolutionWorldBuilderImpl
==========

to

==========
Merge WorldImpl with ResolutionWorldBuilderImpl

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d0279d7c3e687095978e6c5bd7cde103a294ebb5
==========

[Johnni Winther, 2016-12-21 08:57:36]

Committed patchset #2 (id:20001) manually as
d0279d7c3e687095978e6c5bd7cde103a294ebb5 (presubmit successful).