| OLD | NEW |
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 1249 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 1260 results.extend(_CheckJavaStyle(input_api, output_api)) | 1260 results.extend(_CheckJavaStyle(input_api, output_api)) |
| 1261 return results | 1261 return results |
| 1262 | 1262 |
| 1263 | 1263 |
| 1264 def GetTryServerMasterForBot(bot): | 1264 def GetTryServerMasterForBot(bot): |
| 1265 """Returns the Try Server master for the given bot. | 1265 """Returns the Try Server master for the given bot. |
| 1266 | 1266 |
| 1267 Assumes that most Try Servers are on the tryserver.chromium master.""" | 1267 Assumes that most Try Servers are on the tryserver.chromium master.""" |
| 1268 non_default_master_map = { | 1268 non_default_master_map = { |
| 1269 'linux_gpu': 'tryserver.chromium.gpu', | 1269 'linux_gpu': 'tryserver.chromium.gpu', |
| 1270 'win_gpu': 'tryserver.chromium.gpu', |
| 1270 } | 1271 } |
| 1271 return non_default_master_map.get(bot, 'tryserver.chromium') | 1272 return non_default_master_map.get(bot, 'tryserver.chromium') |
| 1272 | 1273 |
| 1273 | 1274 |
| 1274 def GetDefaultTryConfigs(bots=None): | 1275 def GetDefaultTryConfigs(bots=None): |
| 1275 """Returns a list of ('bot', set(['tests']), optionally filtered by [bots]. | 1276 """Returns a list of ('bot', set(['tests']), optionally filtered by [bots]. |
| 1276 | 1277 |
| 1277 To add tests to this list, they MUST be in the the corresponding master's | 1278 To add tests to this list, they MUST be in the the corresponding master's |
| 1278 gatekeeper config. For example, anything on master.chromium would be closed by | 1279 gatekeeper config. For example, anything on master.chromium would be closed by |
| 1279 tools/build/masters/master.chromium/master_gatekeeper_cfg.py. | 1280 tools/build/masters/master.chromium/master_gatekeeper_cfg.py. |
| (...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 1350 'mac_nacl_sdk_build': ['compile'], | 1351 'mac_nacl_sdk_build': ['compile'], |
| 1351 'mac_rel': [ | 1352 'mac_rel': [ |
| 1352 'telemetry_perf_unittests', | 1353 'telemetry_perf_unittests', |
| 1353 'telemetry_unittests', | 1354 'telemetry_unittests', |
| 1354 ], | 1355 ], |
| 1355 'win': ['compile'], | 1356 'win': ['compile'], |
| 1356 'win_chromium_compile_dbg': ['defaulttests'], | 1357 'win_chromium_compile_dbg': ['defaulttests'], |
| 1357 'win_chromium_dbg': ['defaulttests'], | 1358 'win_chromium_dbg': ['defaulttests'], |
| 1358 'win_chromium_rel': ['defaulttests'], | 1359 'win_chromium_rel': ['defaulttests'], |
| 1359 'win_chromium_x64_rel': ['defaulttests'], | 1360 'win_chromium_x64_rel': ['defaulttests'], |
| 1361 'win_gpu': ['defaulttests'], |
| 1360 'win_nacl_sdk_build': ['compile'], | 1362 'win_nacl_sdk_build': ['compile'], |
| 1361 'win_rel': standard_tests + [ | 1363 'win_rel': standard_tests + [ |
| 1362 'app_list_unittests', | 1364 'app_list_unittests', |
| 1363 'ash_unittests', | 1365 'ash_unittests', |
| 1364 'aura_unittests', | 1366 'aura_unittests', |
| 1365 'cc_unittests', | 1367 'cc_unittests', |
| 1366 'chrome_elf_unittests', | 1368 'chrome_elf_unittests', |
| 1367 'chromedriver_unittests', | 1369 'chromedriver_unittests', |
| 1368 'components_unittests', | 1370 'components_unittests', |
| 1369 'compositor_unittests', | 1371 'compositor_unittests', |
| (...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 1468 'ios_rel_device', | 1470 'ios_rel_device', |
| 1469 'linux_chromium_chromeos_rel', | 1471 'linux_chromium_chromeos_rel', |
| 1470 'linux_chromium_clang_dbg', | 1472 'linux_chromium_clang_dbg', |
| 1471 'linux_chromium_rel', | 1473 'linux_chromium_rel', |
| 1472 'linux_gpu', | 1474 'linux_gpu', |
| 1473 'mac_chromium_compile_dbg', | 1475 'mac_chromium_compile_dbg', |
| 1474 'mac_chromium_rel', | 1476 'mac_chromium_rel', |
| 1475 'win_chromium_compile_dbg', | 1477 'win_chromium_compile_dbg', |
| 1476 'win_chromium_rel', | 1478 'win_chromium_rel', |
| 1477 'win_chromium_x64_rel', | 1479 'win_chromium_x64_rel', |
| 1480 'win_gpu', |
| 1478 ] | 1481 ] |
| 1479 | 1482 |
| 1480 # Match things like path/aura/file.cc and path/file_aura.cc. | 1483 # Match things like path/aura/file.cc and path/file_aura.cc. |
| 1481 # Same for chromeos. | 1484 # Same for chromeos. |
| 1482 if any(re.search('[/_](aura|chromeos)', f) for f in files): | 1485 if any(re.search('[/_](aura|chromeos)', f) for f in files): |
| 1483 builders.extend([ | 1486 builders.extend([ |
| 1484 'linux_chromeos_asan', | 1487 'linux_chromeos_asan', |
| 1485 'linux_chromium_chromeos_clang_dbg' | 1488 'linux_chromium_chromeos_clang_dbg' |
| 1486 ]) | 1489 ]) |
| 1487 | 1490 |
| 1488 # If there are gyp changes to base, build, or chromeos, run a full cros build | 1491 # If there are gyp changes to base, build, or chromeos, run a full cros build |
| 1489 # in addition to the shorter linux_chromeos build. Changes to high level gyp | 1492 # in addition to the shorter linux_chromeos build. Changes to high level gyp |
| 1490 # files have a much higher chance of breaking the cros build, which is | 1493 # files have a much higher chance of breaking the cros build, which is |
| 1491 # differnt from the linux_chromeos build that most chrome developers test | 1494 # differnt from the linux_chromeos build that most chrome developers test |
| 1492 # with. | 1495 # with. |
| 1493 if any(re.search('^(base|build|chromeos).*\.gypi?$', f) for f in files): | 1496 if any(re.search('^(base|build|chromeos).*\.gypi?$', f) for f in files): |
| 1494 builders.extend(['cros_x86']) | 1497 builders.extend(['cros_x86']) |
| 1495 | 1498 |
| 1496 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it | 1499 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it |
| 1497 # unless they're .gyp(i) files as changes to those files can break the gyp | 1500 # unless they're .gyp(i) files as changes to those files can break the gyp |
| 1498 # step on that bot. | 1501 # step on that bot. |
| 1499 if (not all(re.search('^chrome', f) for f in files) or | 1502 if (not all(re.search('^chrome', f) for f in files) or |
| 1500 any(re.search('\.gypi?$', f) for f in files)): | 1503 any(re.search('\.gypi?$', f) for f in files)): |
| 1501 builders.extend(['android_aosp']) | 1504 builders.extend(['android_aosp']) |
| 1502 | 1505 |
| 1503 return GetDefaultTryConfigs(builders) | 1506 return GetDefaultTryConfigs(builders) |
| OLD | NEW |