ash/launcher/launcher_delegate.h - Issue 25823002: Refactor LauncherItemController and LauncherItemDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/launcher/launcher_delegate.h

Issue 25823002: Refactor LauncherItemController and LauncherItemDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased and DCHECK(LauncherItemDelegate*) for LauncherID Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/launcher/launcher_delegate.h

diff --git a/ash/launcher/launcher_delegate.h b/ash/launcher/launcher_delegate.h

index 41d0c2944e51ba929f878978eb24d5690a74cac9..3766ca331b157f3b14e53597095ef9ddb777c94a 100644

--- a/ash/launcher/launcher_delegate.h

+++ b/ash/launcher/launcher_delegate.h

@@ -25,6 +25,7 @@ class ASH_EXPORT LauncherDelegate {

// there isn't one.

// Note: Windows of tabbed browsers will return the |LauncherID| of the

// currently active tab or selected tab.

+ // TODO(simon.hong81): Remove this and handle in LauncherItemDelegateManager.

virtual LauncherID GetIDByWindow(aura::Window* window) = 0;

// Callback used to allow delegate to perform initialization actions that

« no previous file with comments | « ash/launcher/launcher.cc ('k') | ash/launcher/launcher_item_delegate.h » ('j') | ash/launcher/launcher_item_delegate_manager.cc » ('J')