third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py - Issue 2582293004: Remove use of wdiff from layout test runner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py

Issue 2582293004: Remove use of wdiff from layout test runner. (Closed)

Patch Set: Rebased Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py

index 5f6d18f7ff961e20c178dbc59dd08f1b4dc65c26..298125a7f3bf45a7449dc55eaf2dfbbb905f0020 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py

@@ -364,9 +364,6 @@ class AndroidPort(base.Port):

# See https://codereview.chromium.org/1158323009/

return 1

- def check_wdiff(self, more_logging=True):

- return self._host_port.check_wdiff(more_logging)

def check_build(self, needs_http, printer):

exit_status = super(AndroidPort, self).check_build(needs_http, printer)

if exit_status:

@@ -499,9 +496,6 @@ class AndroidPort(base.Port):

def _path_to_image_diff(self):

return self._host_port._path_to_image_diff()

- def _path_to_wdiff(self):

- return self._host_port._path_to_wdiff()

def _shut_down_http_server(self, pid):

return self._host_port._shut_down_http_server(pid)