Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1700)

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 2582023002: Disable WebViewTest.Shim_TestNestedSubframes on Mac. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/guest_view/web_view_browsertest.cc
diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc
index cf2b44733cec8d9509ae0a8290c486cb5dc0c224..4ede1058fe77f4e98aa117a74979384c30c0a8bf 100644
--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc
@@ -1481,7 +1481,13 @@ IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_TestNestedCrossOriginSubframes) {
"web_view/shim", NEEDS_TEST_SERVER);
}
-IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_TestNestedSubframes) {
+#if defined(OS_MACOSX)
+// Flaky on Mac. See https://crbug.com/674904.
+#define MAYBE_Shim_TestNestedSubframes DISABLED_Shim_TestNestedSubframes
+#else
+#define MAYBE_Shim_TestNestedSubframes Shim_TestNestedSubframes
+#endif
+IN_PROC_BROWSER_TEST_P(WebViewTest, MAYBE_Shim_TestNestedSubframes) {
TestHelper("testNestedSubframes", "web_view/shim", NO_TEST_SERVER);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698