Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 25820003: Use --resetGpuContext flag when running GM on Xoom (Closed)

Created:
7 years, 2 months ago by borenet
Modified:
7 years, 2 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Use --resetGpuContext flag when running GM on Xoom BUG=skia:1434 R=djsollen@google.com, rmistry@google.com Committed: https://code.google.com/p/skia/source/detail?r=11609

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M slave/skia_slave_scripts/run_gm.py View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
borenet
7 years, 2 months ago (2013-10-04 15:15:58 UTC) #1
rmistry
LGTM
7 years, 2 months ago (2013-10-04 15:16:36 UTC) #2
djsollen
https://codereview.chromium.org/25820003/diff/1/slave/skia_slave_scripts/run_gm.py File slave/skia_slave_scripts/run_gm.py (right): https://codereview.chromium.org/25820003/diff/1/slave/skia_slave_scripts/run_gm.py#newcode71 slave/skia_slave_scripts/run_gm.py:71: # msaa16 is flaky on Macs (driver bug?) so ...
7 years, 2 months ago (2013-10-04 15:18:19 UTC) #3
rmistry
https://codereview.chromium.org/25820003/diff/1/slave/skia_slave_scripts/run_gm.py File slave/skia_slave_scripts/run_gm.py (right): https://codereview.chromium.org/25820003/diff/1/slave/skia_slave_scripts/run_gm.py#newcode73 slave/skia_slave_scripts/run_gm.py:73: cmd.append('--resetGpuContext') Could you add a link to skia:1434 here?
7 years, 2 months ago (2013-10-04 15:19:23 UTC) #4
borenet
Patch set 2. https://codereview.chromium.org/25820003/diff/1/slave/skia_slave_scripts/run_gm.py File slave/skia_slave_scripts/run_gm.py (right): https://codereview.chromium.org/25820003/diff/1/slave/skia_slave_scripts/run_gm.py#newcode71 slave/skia_slave_scripts/run_gm.py:71: # msaa16 is flaky on Macs ...
7 years, 2 months ago (2013-10-04 15:22:15 UTC) #5
djsollen
lgtm
7 years, 2 months ago (2013-10-04 15:26:00 UTC) #6
borenet
7 years, 2 months ago (2013-10-04 15:29:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r11609 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698