Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: components/crash/core/browser/resources/crashes.js

Issue 2581983002: Fix Incorrect date/time info under chrome://crashes. (Closed)
Patch Set: Split crash+upload into two separate strings. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/crash/core/browser/crashes_ui_util.cc ('k') | components/crash_strings.grdp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/core/browser/resources/crashes.js
diff --git a/components/crash/core/browser/resources/crashes.js b/components/crash/core/browser/resources/crashes.js
index 89a0bea508d545b866bf6cc69117b632d1543fa3..2feb35d2fbb4d0dc5d6c348941ace0adc8170b01 100644
--- a/components/crash/core/browser/resources/crashes.js
+++ b/components/crash/core/browser/resources/crashes.js
@@ -57,12 +57,19 @@ function updateCrashList(
crash.local_id);
}
crashBlock.appendChild(title);
+ var date = document.createElement('p');
+ date.textContent = ""
+ if (crash.time) {
+ date.textContent += loadTimeData.getStringF('crashTimeFormat',
+ crash.time);
+ }
+ if (crash.upload_time) {
+ date.textContent += loadTimeData.getStringF('crashUploadTimeFormat',
Wez 2016/12/27 21:47:12 Note that the format strings don't include any pun
+ crash.upload_time);
+ }
+ crashBlock.appendChild(date);
+
if (uploaded) {
- var date = document.createElement('p');
- date.textContent = loadTimeData.getStringF('crashTimeFormat',
- crash.time,
- crash.upload_time);
- crashBlock.appendChild(date);
var linkBlock = document.createElement('p');
var link = document.createElement('a');
var commentLines = [
« no previous file with comments | « components/crash/core/browser/crashes_ui_util.cc ('k') | components/crash_strings.grdp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698