Fix Incorrect date/time info under chrome://crashes.

components/crash/core/browser/resources/crashes.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /* Id for tracking automatic refresh of crash list.  */
 var refreshCrashListId = undefined;
 
 /**
  * Requests the list of crashes from the backend.
  */
@@ skipping 39 matching lines @@
     var uploaded = crash.state == 'uploaded';
     if (uploaded) {
       title.textContent = loadTimeData.getStringF('crashHeaderFormat',
                                                   crash.id,
                                                   crash.local_id);
     } else {
       title.textContent = loadTimeData.getStringF('crashHeaderFormatLocalOnly',
                                                   crash.local_id);
     }
     crashBlock.appendChild(title);
+    var date = document.createElement('p');
+    date.textContent = ""
+    if (crash.time) {
+      date.textContent += loadTimeData.getStringF('crashTimeFormat',
+      crash.time);
+    }
+    if (crash.upload_time) {
+      date.textContent += loadTimeData.getStringF('crashUploadTimeFormat',

[Wez, 2016/12/27 21:47:12]

Note that the format strings don't include any punctation, so in the case of
both crash.time and crash.upload_time being set, we need to either include
punctuation in the format strings, or add it here.

As phistuck@gmail previously suggested, we can do more natural translations if
we have a single format string, so the other alternative would be to have
*three* format strings (crash-only, upload-only, crash+upload), and update the
JS etc accordingly.

+      crash.upload_time);
+    }
+    crashBlock.appendChild(date);
+
     if (uploaded) {
-      var date = document.createElement('p');
-      date.textContent = loadTimeData.getStringF('crashTimeFormat',
-                                                 crash.time,
-                                                 crash.upload_time);
-      crashBlock.appendChild(date);
       var linkBlock = document.createElement('p');
       var link = document.createElement('a');
       var commentLines = [
         'IMPORTANT: Your crash has already been automatically reported ' +
         'to our crash system. Please file this bug only if you can provide ' +
         'more information about it.',
         '',
         '',
         'Chrome Version: ' + version,
         'Operating System: ' + os,
@@ skipping 78 matching lines @@
 
   // Trigger a refresh in 5 seconds.  Clear any previous requests.
   clearTimeout(refreshCrashListId);
   refreshCrashListId = setTimeout(requestCrashes, 5000);
 }
 
 document.addEventListener('DOMContentLoaded', function() {
   $('uploadCrashes').onclick = requestCrashUpload;
   requestCrashes();
 });