Issue 25819002: Revert 210101 "cc: Fix and simplify DelayBasedTimeSource"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25819002: Revert 210101 "cc: Fix and simplify DelayBasedTimeSource" (Closed)

Created:
7 years, 2 months ago by jbauman

Modified:
7 years, 2 months ago

Reviewers:
brianderson

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1599_59/src/

Visibility:
Public.

Revert 210101 "cc: Fix and simplify DelayBasedTimeSource" > cc: Fix and simplify DelayBasedTimeSource > > - This converts some floating point math to integer math > to avoid rounding errors. > > - Assigns last_tick_time_ to be the time it was *supposed* > to tick and no longer uses it as a synonym for "now". > > - Adds trace events to help debug when the interval or > phase changes. > > BUG=256650 > > Review URL: https://chromiumcodereview.appspot.com/18589002 TBR=brianderson@chromium.org BUG=262437 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226617

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -38 lines)			Patch
M	cc/scheduler/delay_based_time_source.h	View	3 chunks	+8 lines, -1 line	0 comments	Download
M	cc/scheduler/delay_based_time_source.cc	View	9 chunks	+46 lines, -27 lines	0 comments	Download
M	cc/scheduler/delay_based_time_source_unittest.cc	View	10 chunks	+10 lines, -10 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r226617.