media/mojo/services/BUILD.gn - Issue 2581893002: Use the /WX flag to have link warnings treated as errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/services/BUILD.gn

Issue 2581893002: Use the /WX flag to have link warnings treated as errors. (Closed)

Patch Set: Move /WX setter into :compiler and respect fatal_linker_warnings Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/mojo/services/BUILD.gn

diff --git a/media/mojo/services/BUILD.gn b/media/mojo/services/BUILD.gn

index f64a5e1f0f8f4cd1c1c3275e5ec570e69b795677..3ee32122d8a77b323f362178a09b65a4ce6b0811 100644

--- a/media/mojo/services/BUILD.gn

+++ b/media/mojo/services/BUILD.gn

@@ -132,6 +132,11 @@ source_set("lib") {

service("media") {

testonly = true

+ # crbug.com/676418: Suppress symbol import warnings.

+ if (is_win && is_component_build) {

+ ldflags = [ "/ignore:4217" ]

+ }

sources = [

"main.cc",

]

« no previous file with comments | « media/mojo/BUILD.gn ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »